refactor(errors): wire missing From edges into Fault - #113
Open
mfw78 wants to merge 4 commits into
Open
Conversation
AI Assistance: Claude Fable 5 used for the From wiring, call-site conversion, and gate runs
AI Assistance: Claude Opus 5 used for the red-team review and fixes
AI Assistance: Claude Opus 5 used for the red-team review and fixes
AI Assistance: Claude Opus 5 used for the red-team review and fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Wires the missing
Fromconversions across the L1 error seams and foldsConfigError/AddressParseintoFault::InvalidInput.Adds regression tests that pin the fold behaviour for both error types.
Derives the price-alert direction vocabulary with
struminstead of hand-rolled matching, and drops a stale issue reference from a code comment.Why
Closes #50
Seam methods returned typed errors but callers still bridged them by hand with
.map_err(...)because theFromedges were missing.Wiring
From<ConfigError> for FaultandFrom<AddressParse> for Faultlets call sites use bare?, matching the existingChainError -> Faultreference pattern.Testing
config_error_folds_into_an_invalid_input_faultandaddress_parse_folds_into_an_invalid_input_faultadded to guard the newFaultfolds.types/t4-typed-errors(13 files changed) to confirm no unrelated changes leaked in.AI Assistance
Implementation: claude-fable-5. Red-team: claude-opus-5. PR: claude-sonnet-5.