refactor(runtime)!: harvest the #94-audited dead seams - #105
Merged
Conversation
Extension state flows through HostState.services; the Ext slot, ExtState, the harness ext payload seam, and the MockTypes generic parameter had no consumer. Components, ComponentsBuilder, and the Runtime preset lose the extension-payload slot; MockTypes becomes a unit marker. AI Assistance: Fable 5 used for implementation
EngineConfigError, EnvVarError, DigestParseError, and ParseError lose the derive; no consumer exercises the static-str conversion. strum stays for LogSource, and the dependency rationale now says so. AI Assistance: Fable 5 used for implementation
… derives Entry loses From<ManifestSource> and From<&Path>, ManifestSource loses From<&TestManifest> and From<&Path>; no call site consumes them. ModuleId loses AsRef, Ord, and PartialOrd; nothing keys or sorts by it. AI Assistance: Fable 5 used for implementation
…untime add_ons becomes an owned AddOns and wasm/manifest become Option<PathBuf>, dropping the borrowed-slice threading, both add_on_refs bridge blocks, and the AssembledRuntime lifetime. AI Assistance: Fable 5 used for implementation
The lattice names one seam now that the Ext slot is gone. AI Assistance: Fable 5 used for review and the doc correction
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Deletes the downstream-audited dead surfaces on
RuntimeTypes/AssembledRuntimeper thedecision doc on #94:
RuntimeTypes::Extbounds,HostState.ext,ExtState, the harnessbuilder_with_extseam, and the
MockTypes<E>generic parameter (verdict: DELETE-CLEAR, zero downstream.extreads orExt =bounds; extension state travels viaHostState.services).IntoStaticStronEngineConfigError,EnvVarError,DigestParseError, andParseError(verdict: DELETE-CLEAR, zero downstream references to any of the four enums; downstream
derives
IntoStaticStron its own enums instead).test_utilsEntry/ManifestSourceFromimpls with no in-tree call site (verdict:DELETE-NOW, unexercised; never published at the pinned downstream rev).
ModuleIdOrd/PartialOrd/AsRef(verdict: DELETE-NOW, downstream reads moduleidentity as
&strand imposes no ordering contract;as_str/Borrow<str>are kept).AssembledRuntimeborrowed-slice fields, flipped to ownedAddOnsandOption<PathBuf>(verdict: DELETE-CLEAR/flip freely, zero downstream references toAssembledRuntimeor add-on refs).Kept per the same audit and left untouched:
engine_configquota()/watch()/status_poll_interval(),actor.rsSupervisedStore/ActorSlot/ActorFault, andbuild_provider_linker, all of which have live downstream call sites.A trailing doc commit updates the
RuntimeTypesmodule docs to describe the singleremaining store seam now that the Ext axis is gone.
Why
Part of #94.
Testing
just cirun locally againstseam/harvestat 40541b4: rustfmt --check, clippy--workspace --all-targets --all-features -D warnings, cargo doc, the wasm32-wasip2
fixture/example builds,
cargo nextest run --workspace --all-features --no-fail-fast(665 tests run, 665 passed, 0 skipped), and
cargo test --doc --workspace --all-features(2 doctests passed, 1 ignored, across nexum-runtime and nexum-sdk).Full run exited 0.
AI Assistance
Implement claude-fable-5, red-team claude-opus-5, PR claude-sonnet-5.