fix(supervisor): bound provider install by dispatch deadline - #104
Merged
Conversation
AI Assistance: Claude Fable 5 used for implementation and tests
AI Assistance: Claude Opus 5 used for the adversarial review and these fixes.
This was referenced Aug 6, 2026
runtime: consolidate the post-train seams (builder tail, Role vocabulary, load-path convergence)
#94
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Wraps both
ProviderKind::installcall sites (revive and boot) in the dispatch deadline, so a hung providerinstallfails instead of parking the sweep, and with it all dispatch.Part of #94
Why
A hung install in revive parks the sweep forever because the sweep runs inline (dispatch.rs). Bounding
install_providerby the seed'sevent_deadlinecloses that hole and applies the same bound at the boot call site.This is a maintainer-approved change to the
ProviderKind::installcontract: the deadline plus cancel-safety requirement is now documented directly on the trait method. Becauseinstallspans instantiation, guestinit, and extension wiring rather than a single guest call, a timeout can drop the future mid-flight and must leave no half-registered actor in the extension service. Every downstreamProviderKindimpl now has to uphold that cancel-safety contract.videre::VenueAdapterKindis the single downstream impl that adapts to it.Testing
cargo nextest run -p nexum-runtime: 434 tests run, 434 passed, 0 skipped, including the two new deadline testsa_hanging_provider_install_fails_by_deadlineanda_hanging_provider_install_refuses_the_boot_by_deadline, both understart_paused = trueasserting the install rides the seed's deadline rather than any other timer.AI Assistance
implement claude-fable-5, red-team claude-opus-5, PR claude-sonnet-5.