chore(runtime): sweep post-seam cruft from C1-C5 - #101
Merged
Conversation
mfw78
force-pushed
the
seam/c5-load-convergence
branch
from
August 6, 2026 07:32
c84f78c to
c19a510
Compare
mfw78
force-pushed
the
seam/c5-load-convergence
branch
from
August 6, 2026 07:36
c19a510 to
eb1478c
Compare
mfw78
force-pushed
the
seam/c5-load-convergence
branch
from
August 6, 2026 07:51
eb1478c to
5c03068
Compare
LifecycleState, Role, and FilterError never convert to &'static str; the crate manifest rationale now states the pub-enum surface only. AI Assistance: Fable 5 used for cruft analysis and implementation
…ives poisoned_count is pub, so dead_code cannot fire; DispatchOutcome is consumed only through matches!, never compared. AI Assistance: Fable 5 used for cruft analysis and implementation
Neither is referenced outside supervisor/; LifecycleState never leaves lifecycle.rs. AI Assistance: Fable 5 used for cruft analysis and implementation
The cfg(test) use ladder and TestTypes lattice lived in supervisor/mod.rs only to feed the tests glob; preset::CoreRuntime already provides the identical core-only lattice, so the bespoke test types collapse into it. AI Assistance: Fable 5 used for cruft analysis and implementation
Entry keeps TestManifest/String/PathBuf conversions and ManifestSource keeps TestManifest/String/PathBuf; the by-reference and pass-through variants convert nowhere in the tree. AI Assistance: Fable 5 used for cruft analysis and implementation
as_str and Borrow<str> cover every string read; nothing calls as_ref. AI Assistance: Fable 5 used for cruft analysis and implementation
AI Assistance: Fable 5 used for cruft analysis and implementation
The five event_loop retry sites keep their own log lines and fields; only the attempt bump, backoff computation, and sleep converge. AI Assistance: Fable 5 used for cruft analysis and implementation
…sions AsRef<str> on ModuleId and the by-reference and pass-through From impls on Entry and ManifestSource are published API, so they stay until the downstream consumer audit clears them. AI Assistance: Opus 5 used for red-team review and the restore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Strips dead and inert code left over from the C1-C5 seam work: unconsumed derives, unused From impls, an inert allow, and a private-visibility tightening on supervisor Health/LifecycleState, plus a share of the retry-bump/sleep logic behind a common backoff_pause helper and a revert restoring the downstream-visible ModuleId and test-utils conversions.
Why
Part of #94
The seam stack accumulated small pockets of cruft (unused derives, dead From impls, an inert allow, duplicated retry/sleep logic) as each carve landed independently; this pass sweeps them up before the runtime seam is considered converged.
Testing
Independent gate on a fresh clone of nullislabs/nexum-runtime, detached at origin/seam/c6-cruft = e1e9d8b.
Base confirmed via merge-base against origin/seam/c5-load-convergence: clean 9-commit fast-forward stack on top of C5, no drift, no merge.
Diff over the base range: 16 files, +122/-162, all under crates/nexum-runtime.
CI-parity battery run inside nix develop, exit codes captured explicitly: cargo fmt --all -- --check (0), cargo clippy --workspace --all-targets --all-features --locked -- -D warnings (0, zero warning/error matches), just build for wasm32-wasip2 release (0), CI=1 cargo nextest run --workspace --all-features --locked (0, 656/656 passed), cargo test --doc --workspace --all-features --locked (0), RUSTDOCFLAGS='-D warnings' cargo doc --workspace --no-deps --locked (0), just test-e2e (0, 11/11 passed).
Commit hygiene over the 9-commit range: all commits authored and committed by mfw78 mfw78@nxm.rs with good signatures, no AI-attribution footers, and zero em-dashes in added lines or commit messages.
AI Assistance
Implemented by claude-fable-5, red-teamed by claude-opus-5, PR opened by claude-sonnet-5.