refactor(supervisor): converge boot and restart load pipelines - #100
Merged
Conversation
mfw78
force-pushed
the
seam/c5-load-convergence
branch
from
August 6, 2026 07:32
c84f78c to
c19a510
Compare
mfw78
force-pushed
the
seam/c5-load-convergence
branch
from
August 6, 2026 07:36
c19a510 to
eb1478c
Compare
AI Assistance: Claude (Fable 5) used for implementation and test updates
…eats AI Assistance: Claude (Fable 5) used for implementation and test updates
AI Assistance: Claude (Opus 5) used for red-team review and test authoring
AI Assistance: Claude (Opus 5) used for red-team review and the visibility fix
mfw78
force-pushed
the
seam/c5-load-convergence
branch
from
August 6, 2026 07:51
eb1478c to
5c03068
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Converges the boot and restart load pipelines for modules and providers into shared
helpers instead of duplicated skeletons: a shared store-build helper parameterised by
role, shared instantiate/install helpers reused by both the initial load path and the
lifecycle revive path, and a merged Seed type replacing the separate ModuleSeed and
ProviderSeed literals.
Confines run_init to the instantiate seam, drops the boot-only refuel that the dispatch
path already repeats, and adds a regression test pinning the boot-kills vs
restart-defers init verdict so the converged pipelines keep that distinction visible at
the call sites.
Why
Part of #94
The boot and restart load paths carried twin implementations that had drifted apart in
small, hard-to-audit ways (duplicated store-build logic, duplicated seed literals, a
refuel step only one path needed). Converging them onto shared helpers removes that
duplication while keeping the one deliberate behavioural difference, dead-permanent
vs restart-defers on init, explicit at both call sites instead of buried in copies.
Testing
AI Assistance
Implementation by Claude (Fable 5), red-team review by Claude (Opus 5), PR by Claude (Sonnet 5).