Skip to content

fix: rename the last ComposableCoW-cased test filename - #47

Merged
mfw78 merged 1 commit into
developfrom
fix/test-filename-casing
Jul 31, 2026
Merged

fix: rename the last ComposableCoW-cased test filename#47
mfw78 merged 1 commit into
developfrom
fix/test-filename-casing

Conversation

@mfw78

@mfw78 mfw78 commented Jul 30, 2026

Copy link
Copy Markdown

test/ComposableCoW.t.sol was missed by the rename in #44, leaving it as the only remaining ComposableCoW-cased filename in the tree that is not a deliberate exception.

The pattern used in #44 matched test/ComposableCoW.*.t.sol, which requires a middle segment (.base., .twap., ...). The one file without one never matched. Its contents were renamed correctly, so a search over file bodies came back clean and the miss went unnoticed.

Filename only, zero content change: the contract inside is already ComposableCowTest, nothing references the path, and .gas-snapshot keys off contract names rather than filenames.

Remaining ComposableCoW-cased paths after this are both deliberate: audits/gnosis-ComposableCoWMayJul2023.pdf (published artefact) and broadcast/StandardJsonInput/ComposableCoW.json (historical deployment record).

How to test

git ls-tree -r --name-only HEAD | rg 'ComposableCoW'

Returns only the two intentional exceptions above.

Part of #1.

@mfw78
mfw78 force-pushed the style/in-body-comments branch from 7bdae74 to b569442 Compare July 30, 2026 08:23
@mfw78
mfw78 force-pushed the fix/test-filename-casing branch from df7be86 to 386811e Compare July 30, 2026 08:23
@mfw78
mfw78 force-pushed the style/in-body-comments branch from b569442 to 7229256 Compare July 30, 2026 08:42
@mfw78
mfw78 force-pushed the fix/test-filename-casing branch from 386811e to 17c020d Compare July 30, 2026 08:42
@mfw78
mfw78 force-pushed the style/in-body-comments branch from 7229256 to fe5f94f Compare July 30, 2026 09:51
@mfw78
mfw78 force-pushed the fix/test-filename-casing branch from 17c020d to 95fb1de Compare July 30, 2026 09:51
@mfw78
mfw78 force-pushed the style/in-body-comments branch from fe5f94f to 8182be8 Compare July 30, 2026 09:54
@mfw78
mfw78 force-pushed the fix/test-filename-casing branch from 95fb1de to 44e0fb7 Compare July 30, 2026 09:54
@mfw78
mfw78 force-pushed the style/in-body-comments branch from 8182be8 to fe2cdf4 Compare July 30, 2026 10:24
@mfw78
mfw78 force-pushed the fix/test-filename-casing branch from 44e0fb7 to 3697732 Compare July 30, 2026 10:24
@mfw78
mfw78 force-pushed the style/in-body-comments branch from fe2cdf4 to 34795a3 Compare July 30, 2026 10:40
@mfw78
mfw78 force-pushed the fix/test-filename-casing branch 2 times, most recently from 5fd82fd to df090b8 Compare July 30, 2026 12:54
@mfw78
mfw78 force-pushed the style/in-body-comments branch from 34795a3 to 6188459 Compare July 30, 2026 12:54
@mfw78
mfw78 force-pushed the fix/test-filename-casing branch from df090b8 to bce18c0 Compare July 30, 2026 13:07
@mfw78
mfw78 force-pushed the style/in-body-comments branch from 6188459 to 5e0d504 Compare July 30, 2026 13:07
@mfw78
mfw78 force-pushed the fix/test-filename-casing branch from bce18c0 to b83424e Compare July 30, 2026 13:19
@mfw78
mfw78 force-pushed the style/in-body-comments branch 2 times, most recently from 47f2219 to 7a7e6cf Compare July 30, 2026 13:55
@mfw78
mfw78 force-pushed the fix/test-filename-casing branch 2 times, most recently from 2af8f1d to b2e4dd0 Compare July 30, 2026 14:25
@mfw78
mfw78 force-pushed the style/in-body-comments branch 2 times, most recently from 2034f3a to 72fdc2b Compare July 30, 2026 23:43
@mfw78
mfw78 force-pushed the fix/test-filename-casing branch 2 times, most recently from 5a8ff7b to d1d1cd6 Compare July 30, 2026 23:51
@mfw78
mfw78 force-pushed the style/in-body-comments branch from 72fdc2b to 803b2f8 Compare July 30, 2026 23:51
@mfw78
mfw78 force-pushed the fix/test-filename-casing branch from d1d1cd6 to c13ad13 Compare July 31, 2026 00:06
@mfw78
mfw78 force-pushed the style/in-body-comments branch from 803b2f8 to 49bcb00 Compare July 31, 2026 00:06
@mfw78
mfw78 force-pushed the fix/test-filename-casing branch from c13ad13 to deb0a9d Compare July 31, 2026 00:12
@mfw78
mfw78 force-pushed the style/in-body-comments branch from 49bcb00 to c312d8d Compare July 31, 2026 00:12
@mfw78
mfw78 force-pushed the style/in-body-comments branch from de716d6 to 0267b62 Compare July 31, 2026 04:00
@mfw78
mfw78 force-pushed the fix/test-filename-casing branch 2 times, most recently from f1a3bca to 4eed4c9 Compare July 31, 2026 06:10
@mfw78
mfw78 force-pushed the style/in-body-comments branch from 001c0a5 to 469fe25 Compare July 31, 2026 06:10
@mfw78
mfw78 force-pushed the fix/test-filename-casing branch from 4eed4c9 to be645de Compare July 31, 2026 06:14
@mfw78
mfw78 force-pushed the style/in-body-comments branch from 469fe25 to f7b6d6e Compare July 31, 2026 06:14
@mfw78
mfw78 force-pushed the fix/test-filename-casing branch from be645de to 0e79401 Compare July 31, 2026 06:29
@mfw78
mfw78 force-pushed the style/in-body-comments branch from f7b6d6e to 129e08d Compare July 31, 2026 06:29
@mfw78
mfw78 force-pushed the fix/test-filename-casing branch from 0e79401 to 348e388 Compare July 31, 2026 06:31
@mfw78
mfw78 force-pushed the style/in-body-comments branch 2 times, most recently from 1580f39 to cbad447 Compare July 31, 2026 06:42
@mfw78
mfw78 force-pushed the fix/test-filename-casing branch from 348e388 to 4fb381d Compare July 31, 2026 06:42
@github-actions

Copy link
Copy Markdown


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@mfw78
mfw78 force-pushed the fix/test-filename-casing branch from 4fb381d to 552c165 Compare July 31, 2026 06:54
@mfw78
mfw78 force-pushed the style/in-body-comments branch 2 times, most recently from 29caf59 to 2857666 Compare July 31, 2026 07:54
@mfw78
mfw78 force-pushed the fix/test-filename-casing branch from 552c165 to fec23f0 Compare July 31, 2026 07:54
@mfw78
mfw78 force-pushed the style/in-body-comments branch from 2857666 to 021f296 Compare July 31, 2026 08:10
@mfw78
mfw78 force-pushed the fix/test-filename-casing branch 2 times, most recently from 47d2ed4 to 509e89b Compare July 31, 2026 08:34
@mfw78
mfw78 force-pushed the style/in-body-comments branch 2 times, most recently from 382d5d9 to 5efd31f Compare July 31, 2026 10:02
@mfw78
mfw78 force-pushed the fix/test-filename-casing branch 2 times, most recently from 9675eed to de99121 Compare July 31, 2026 10:17
@mfw78
mfw78 force-pushed the style/in-body-comments branch from 5efd31f to d406c7b Compare July 31, 2026 10:17
Base automatically changed from style/in-body-comments to develop July 31, 2026 10:40
`test/ComposableCoW.t.sol` was missed by the rename in #44. The pattern used
there matched `test/ComposableCoW.*.t.sol`, which requires a middle segment,
so the one file without one slipped through. Its contents were renamed
correctly, which is why a content search over file bodies did not catch it.

Filename only: the contract inside is already `ComposableCowTest` and nothing
references the path.
@mfw78
mfw78 force-pushed the fix/test-filename-casing branch from de99121 to 48ff6b9 Compare July 31, 2026 10:41
@mfw78
mfw78 merged commit e695b9e into develop Jul 31, 2026
1 check passed
@mfw78
mfw78 deleted the fix/test-filename-casing branch July 31, 2026 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant