Repository navigation
fix(web): pinned threads stay at the top while they work - #99
Merged
nullStack65 merged 1 commit intoNov 19, 2026
Merged
Conversation
A pinned thread moved into the Working shelf while it ran or waited. Only unpinned active threads go to Working now; a pinned thread keeps its place and shows its status in place. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Owner
Author
|
Independent bot review (Claude Sonnet 5.5): reviewed head 80fc97f against base release/native-0.1.10. Read-only; I could not run the tests ( Verdict: no blocking findings. One non-blocking behavior note. Findings
Checked with no problem found
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A pinned thread moved into the Working shelf while it ran or waited, so a pin did not keep a thread at the top.
resolveSidebarShelfnow moves only unpinned active threads into Working. A pinned thread stays in Pinned in its pinned order whatever its status (running, waiting on its own agents, needs approval, needs input, failed, idle) and its row still shows its status in place. Unpinned threads use the Working shelf as before.Tests: the old "pinned thread … under Working" case is replaced by its inverse over each status. A new drag case checks that a pinned thread reorders within Pinned, unpins onto Active and cannot drop on a Working row. It sits in
Sidebar.logic.test.tsbecause that is whereresolveSidebarDropTargetis tested. Both sidebar test files pass (130 of 130) and web typecheck passes.Filters (decision): the inbox, environment and "from" filters run on every thread before the Pinned/Active/Working split. A pinned thread is hidden only when the user's own filter excludes it, and its status never changes that. I left that as is rather than exempting pins from filters, which would widen scope.
Checks:
check:changedknip fails on the upstream unused files already on the base branch; none are in files this PR touches.Deploy: fleet
🤖 Generated with Claude Code