Skip to content

Report the build commit, qualify every release head, and require a Deploy line - #95

Merged
nullStack65 merged 3 commits into
release/native-0.1.10from
feat/native-0.1.10-done-means-live
Nov 19, 2026
Merged

nullStack65 merged 3 commits into
release/native-0.1.10from
feat/native-0.1.10-done-means-live

Conversation

@nullStack65

@nullStack65 nullStack65 commented Nov 19, 2026 •

Copy link
Copy Markdown
Owner

Why

About 20 merged pull requests into this release branch sat unused for hours on 2026-11-18, because "merged" was treated as "done". This gives a deployment check what it needs to prove what actually runs.

What changes

  1. Build commit in the environment descriptor. /.well-known/t3/environment gains an optional buildCommit: the full source commit, baked in at build time from T3CODE_BUILD_COMMIT and validated as 40 hex characters. It's absent on unstamped builds, and older clients keep decoding the descriptor.
  2. Every release-branch head gets qualified. The ARC qualification job ("Voice + founder inbox (Linux ARC)") also runs on pushes to release/native-0.1.10, with the same trusted-actor and exact-branch guards. Push runs group by commit, so a burst of merges doesn't cancel a queued head. Skipped or cancelled runs must be treated as not passed by anything that reads them.
  3. Deploy: line on pull requests into this branch. Exactly one line, Deploy: none or Deploy: fleet, outside code blocks. The value is deliberately opaque: the private deployment config decides which machines a fleet change goes to, so no host names are published here. The job reads only the event payload (no checkout, token or repository code), so it runs on a GitHub-hosted runner instead of the private one.

Split out of this PR

The desktop "staged build, click to restart" channel was in the first revision. One review round found defects in it, so it moved to its own branch for a rework and will come back as a separate PR. The defects: a remote update request could restart into the staged build, the macOS path can't work, refusals showed as success, and there were gaps in watching and recovery.

Verification

  • Contracts environment.test.ts: 2 passed. Contracts typecheck: 0 errors.
  • The Deploy-line script, run locally against 9 sample bodies (valid, none, missing, host name, two lines, fenced example, indented, injection attempt, CRLF): all as expected.
  • Server typecheck and build: covered by the ARC job on this PR.

Deploy: fleet

🤖 Generated with Claude Code

nullStack65 and others added 3 commits November 19, 2026 03:15
The environment descriptor gains an optional buildCommit, baked in at build
time from T3CODE_BUILD_COMMIT (40-hex, validated), so a deployment check can
read exactly which commit a server runs. Pushes to release/native-0.1.10 now
run the ARC qualification job on their exact commit, and pull requests into
that branch must declare a Deploy: line.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The unquoted name contained ": ", which YAML read as a mapping, so GitHub
rejected the workflow and the check never ran.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
(cherry picked from commit 1c8cada)
…s check

Review round fixes: the public Deploy line now takes only 'none' or 'fleet'
(the private deployment config resolves targets), ignores fenced code, and
runs on a hosted runner because it reads only the event payload. Push runs
group by commit so a burst of merges never cancels a queued head. CI runs the
descriptor contract test.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@nullStack65
nullStack65 force-pushed the feat/native-0.1.10-done-means-live branch from 1c8cada to c73dbd3 Compare November 19, 2026 03:15
@nullStack65 nullStack65 changed the title Report the build commit, qualify every release head, and offer staged desktop builds Report the build commit, qualify every release head, and require a Deploy line Nov 19, 2026
@nullStack65
nullStack65 merged commit 92c857e into release/native-0.1.10 Nov 19, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant