Skip to content

fix(web): inbox action threads stay in the active list while they work - #87

Merged
nullStack65 merged 2 commits into
release/native-0.1.10from
fix/inbox-action-threads-stay-active
Nov 19, 2026
Merged

nullStack65 merged 2 commits into
release/native-0.1.10from
fix/inbox-action-threads-stay-active

Conversation

@nullStack65

Copy link
Copy Markdown
Owner

Problem: a thread routed to a founder as an action item disappeared from that founder's inbox while its run was live (running or waiting on a child task). partitionSidebarThreads sent every working thread to the Working shelf, which is collapsed by default. Reported for the "Dis Dat fork: requested review improvements…" thread in Kameron's inbox.

Fix: new pure staysActiveWhileWorking(inbox, view) next to founderInboxLane in packages/contracts/src/threadInbox.ts: true when the view is a founder's and that founder's lane is action. The partition skips the Working shelf for those threads, so they stay in the active list (the row keeps its working indicator). Every other thread keeps today's behavior. Covered by a unit test of the function, not rendered markup.

Base: feat/native-0.1.10-founder-inbox-lanes (the live R720 build, c540875, is an ancestor).

Overlap: the "T3 sidebar: multi-select inbox" lane edits the same sidebar. The Sidebar.tsx diff is small: an import, one inboxView input on the partition, and one extra condition in inbox(). If that lane replaces the single inboxView, only that condition needs to follow it.

Verified: threadInbox.test.ts 18/18 pass, tsc --noEmit on apps/web is clean, and vp fmt --check passes on the touched files. vp lint and the web Sidebar.logic.test.ts couldn't run here because the host has Node 22 and the repo needs Node 26 for its .ts configs.

Model: claude-sonnet-5-5
Task: fix

🤖 Generated with Claude Code

@nullStack65
nullStack65 force-pushed the fix/inbox-action-threads-stay-active branch from 4d2e387 to 7d0e324 Compare November 18, 2026 22:33
@nullStack65

Copy link
Copy Markdown
Owner Author

🤖 claude-fable-5-2 independent review on behalf of nullStack65 (overnight coordinator, one bot review round)

Verdict: APPROVE

Pinned head: 7d0e324ecd5d2b16cfeca8f077b89e63488d6bbe (this PR's two commits, 44024dff and 7d0e324e, on base feat/native-0.1.10-founder-inbox-lanes).

Read-only review by reading the diff and the surrounding files at the pinned head. I ran no tests, builds or type checks; the only check reported on this head is CodeRabbit, which skipped ("reviews are disabled for this base branch"), so there is no CI evidence for it.

Blocking findings

None.

What I checked

  1. Partition change is correct for the reported bug. apps/web/src/components/Sidebar.tsx:652-657: the new condition only ever moves a thread from working to active; pinned, snoozed and settled routing (Sidebar.tsx:684-697) is untouched, and it applies to the optimistic-drop path too (Sidebar.tsx:679). A thread with an open decision request for a shown founder whose run is live now stays visible, which is the reported case.
  2. Predicate matches the base branch's lane definition. packages/contracts/src/threadInbox.ts:250-257 reuses founderInboxLane (threadInbox.ts:216-225), so FYI, agent-only, reason-less agent work and null/undefined inboxes return false and keep the Working shelf. Agents and Shared are never iterated because it loops Founder.literals only.
  3. Multi-select follow-up is consistent. Sidebar.tsx:464 reads the same effectiveInboxFilter the list filter uses (apps/web/src/components/sidebar/threadListFilter.logic.ts:35), so "shown" means the same thing in both places.
  4. No render loop from the new selector. effectiveInboxFilter can return a fresh array (threadInbox.ts:240), but useClientSettings compares selections with Equal.equals (apps/web/src/hooks/useSettings.ts:322-332), the same pattern as threadListFilterOf at Sidebar.tsx:1121.
  5. Types by reading. thread.source.inbox is ThreadInbox | null | undefined, the shape the predicate accepts (same access as threadListFilter.logic.ts:41). InboxChoice and Founder literals line up with filter.includes(founder).
  6. Return tracker is unaffected. inboxReturns.observe still sees every thread (Sidebar.tsx:648), and sortInboxThreadsByReturn (packages/client-runtime/src/state/threadInbox.ts:57-75) does not assume active threads are idle.

Non-blocking findings

  1. Scope is wider than "routed to a founder as an action item"; please confirm it is intended. A thread a founder starts themselves gets owner = founder, attentionKind: "action" and a human origin (threadInbox.ts:104-135), so founderInboxLane returns "action" for it (threadInbox.ts:219-224). With that founder's inbox shown, which is the default once founderInboxOwner is set (threadInbox.ts:240), none of the founder's own running threads enter the Working shelf any more. The shelf then holds only Agents, Shared, FYI and unclassified threads. This matches the stated intent that working action threads stay in the active list, so I am not blocking on it, but it is a larger behavior change than the PR description's "every other thread keeps today's behavior" suggests.
  2. Tests cover the predicate, not the wiring. packages/contracts/src/threadInbox.test.ts:339-364 covers an agent-routed review thread, hidden inboxes, FYI and unrouted agent work. Missing cases: an open decisionRequest for a shown founder on an otherwise agent-only thread (the threadInbox.ts:218 branch), pendingHumanRequest, and the founder-started thread from finding 1. Nothing exercises partitionSidebarThreads itself, so a later edit dropping the Sidebar.tsx:654 condition would not fail a test.
  3. Unverified by the author: the PR body says vp lint and Sidebar.logic.test.ts could not run on the authoring host (Node 22 vs required Node 26). Those remain unrun at this head.

Not checked

Rendered sidebar behavior in a browser, and the mobile client (I saw no Working shelf in apps/mobile/src/features/home/homeThreadList.ts, but did not read the rest of the mobile list code).

nullStack65 and others added 2 commits November 19, 2026 03:13
A thread waiting on the viewing founder was moved into the collapsed Working
shelf while its run was live, so it vanished from that founder's inbox view.
staysActiveWhileWorking (next to founderInboxLane) keeps founder-lane "action"
threads in the active list; other threads keep today's Working shelf behavior.

Model: claude-sonnet-5-5
Task: fix
Agent: claude-code

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Rebased onto the founder inbox lanes branch, where the single inbox view
became a multi-select filter. An action thread for any shown founder now
stays in the active list while it works.

Model: claude-opus-5-5
Task: fix
Agent: claude-code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@nullStack65
nullStack65 force-pushed the fix/inbox-action-threads-stay-active branch from 7d0e324 to 77addce Compare November 19, 2026 03:14
@nullStack65
nullStack65 changed the base branch from feat/native-0.1.10-founder-inbox-lanes to release/native-0.1.10 November 19, 2026 03:14
@nullStack65 nullStack65 reopened this Nov 19, 2026
@nullStack65
nullStack65 merged commit 5cbc2de into release/native-0.1.10 Nov 19, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant