Repository navigation
fix(web): inbox action threads stay in the active list while they work - #87
Merged
nullStack65 merged 2 commits intoNov 19, 2026
Merged
Conversation
nullStack65
force-pushed
the
fix/inbox-action-threads-stay-active
branch
from
November 18, 2026 22:33
4d2e387 to
7d0e324
Compare
Owner
Author
Verdict: APPROVE Pinned head: Read-only review by reading the diff and the surrounding files at the pinned head. I ran no tests, builds or type checks; the only check reported on this head is CodeRabbit, which skipped ("reviews are disabled for this base branch"), so there is no CI evidence for it. Blocking findingsNone. What I checked
Non-blocking findings
Not checkedRendered sidebar behavior in a browser, and the mobile client (I saw no Working shelf in |
A thread waiting on the viewing founder was moved into the collapsed Working shelf while its run was live, so it vanished from that founder's inbox view. staysActiveWhileWorking (next to founderInboxLane) keeps founder-lane "action" threads in the active list; other threads keep today's Working shelf behavior. Model: claude-sonnet-5-5 Task: fix Agent: claude-code Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Rebased onto the founder inbox lanes branch, where the single inbox view became a multi-select filter. An action thread for any shown founder now stays in the active list while it works. Model: claude-opus-5-5 Task: fix Agent: claude-code Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
nullStack65
force-pushed
the
fix/inbox-action-threads-stay-active
branch
from
November 19, 2026 03:14
7d0e324 to
77addce
Compare
nullStack65
changed the base branch from
feat/native-0.1.10-founder-inbox-lanes
to
release/native-0.1.10
November 19, 2026 03:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: a thread routed to a founder as an action item disappeared from that founder's inbox while its run was live (running or waiting on a child task).
partitionSidebarThreadssent every working thread to the Working shelf, which is collapsed by default. Reported for the "Dis Dat fork: requested review improvements…" thread in Kameron's inbox.Fix: new pure
staysActiveWhileWorking(inbox, view)next tofounderInboxLaneinpackages/contracts/src/threadInbox.ts: true when the view is a founder's and that founder's lane isaction. The partition skips the Working shelf for those threads, so they stay in the active list (the row keeps its working indicator). Every other thread keeps today's behavior. Covered by a unit test of the function, not rendered markup.Base:
feat/native-0.1.10-founder-inbox-lanes(the live R720 build, c540875, is an ancestor).Overlap: the "T3 sidebar: multi-select inbox" lane edits the same sidebar. The
Sidebar.tsxdiff is small: an import, oneinboxViewinput on the partition, and one extra condition ininbox(). If that lane replaces the singleinboxView, only that condition needs to follow it.Verified:
threadInbox.test.ts18/18 pass,tsc --noEmitonapps/webis clean, andvp fmt --checkpasses on the touched files.vp lintand the webSidebar.logic.test.tscouldn't run here because the host has Node 22 and the repo needs Node 26 for its.tsconfigs.Model: claude-sonnet-5-5
Task: fix
🤖 Generated with Claude Code