Skip to content

feat(settings): ship Closura fleet defaults for linking and provider updates - #73

Merged
nullStack65 merged 3 commits into
release/native-0.1.10from
feat/closura-opinionated-defaults
Nov 18, 2026
Merged

nullStack65 merged 3 commits into
release/native-0.1.10from
feat/closura-opinionated-defaults

Conversation

@nullStack65

@nullStack65 nullStack65 commented Nov 18, 2026 •

Copy link
Copy Markdown
Owner

Problem

Kameron, 2026-11-18 about 05:20 ET: "didnt connect mac air. its settimgs require pairing code which needs to be off for all t3 machines. our t3code fork should be opinioated and have batteries included such as our own 'default' settings and auto cloudflare joining (if can be done very simply, otherwise not worth), etc."

Every new Closura T3 install started with Linked environments off. While it is off, the machine refuses links, link cards and calls over a link, so a fresh machine can't join the fleet. Installs also started with stock provider update checks on. The fleet had been fixing both by hand on each machine. ASUS and R720 both carry enableProviderUpdateChecks: false, and closura-agent-config's t3-links component turns Linked environments on.

Change

Built-in defaults in packages/contracts/src/settings.ts:

Setting Stock Closura
linkedEnvironmentsEnabled off on
enableProviderUpdateChecks on off

How existing machines move: the server drops any value equal to the default when it writes settings. So a machine where someone turned Linked environments off, or left update checks on, under stock defaults has no stored key and takes the Closura default on upgrade. Only a value written by hand that differs from the new default (linkedEnvironmentsEnabled: false, enableProviderUpdateChecks: true) survives. The reverse holds too: after the first write on this build, the hand-set enableProviderUpdateChecks: false on ASUS and R720 is dropped as redundant, so a machine rolled back to stock T3 returns to stock defaults (links off, checks on).

The cost of checks off: the same switch gates the T3 model catalog download, Antigravity release checks and background installation update lookups. A fresh Closura machine won't see new models until a T3 release bundles them or someone turns the checks on in Settings → Maintenance. ASUS and R720 already run this way. docs/user/updating.md now says so.

User docs that told people to turn Linked environments on now say it is on by default. Tests that relied on the old defaults now set them explicitly: the McpHttpServer test for "while the beta is off", the ModelManifest fetch helper, and the two ProviderSessionManager reload tests, which now switch the setting off to exercise a change. The agent-context budget isn't affected by this change: it measures the same with either default, and #72 already refreshed it on the base branch.

Checked, and already what Closura wants, so no change:

  • Pairing/approval: requireConnectDeviceApproval already defaults to off. Linked environments on doesn't loosen authentication: the setting only adds refusals, and approving a link still needs a pairing code or a session holding access:write plus a CSRF token. Linking a machine this app is connected to mints the code automatically when the session holds access:write, which every standard and T3 Connect session does. A typed code is only needed for a bare address. Linking still goes through the existing OAuth code exchange.
  • Founder inboxes: built in with no toggle. Founder is kameron | jeff.
  • newWorktreesStartFromOrigin: already defaults to true.
  • Stock desktop auto-update: the Closura desktop recipes (scripts/closura/build-*.sh) embed no update feed, so the packaged app never auto-updates to stock. The server never updates on its own.

Deliberately left out

  1. Background activity profile stays balanced. The brief said "turn on background activity". balanced already runs background refresh, with git fetch every 30s and a provider refresh every 5 minutes, and both ASUS and R720 run it today. performance would also keep background work going for unfocused clients. But it means a git fetch every 15s and a provider refresh every minute on every machine, including the 8 GB laptop. Changing the profile alone also leaves the legacy interval aliases inconsistent, and two tests caught that. My recommendation is to keep balanced. It's a small follow-up if Kameron wants performance.
  2. Cloudflare auto-join is skipped. It isn't simple inside T3. Joining needs cloudflared, a per-host tunnel token from Infisical, Access apps and DNS. closura-agent-config already does all of that in its t3-links workstation component (closura-agent-config PR fix(shell): bound PATH repair fallbacks pingdotgg/t3code#831), with the token kept out of git and logs. Re-implementing it as a first-run step would mean shipping or fetching tunnel credentials from the app. The rollout should run t3-links instead.
  3. No other settings from ASUS's file. Provider instances, binary paths, model selections and idleCompaction are specific to each machine, or are unverified as fleet-wide. No secrets were added.
  4. Manual "Update" to a stock release is still possible. The server only installs a stock npm t3 when someone asks. Closing that path cleanly touches the CLI, self-update and the client gating. That's worth its own PR if wanted.

Verification (ASUS, Node 26.13.1; ASUS load average was about 45)

  • Focused settings and provider-default tests: contracts settings, shared settings, the web and mobile settings logic, and the provider maintenance and driver tests. 10 files, 263 tests passed.
  • Every server and provider test under apps/server/src/provider and packages/provider-*, plus ws, serverSettings and ProviderSessionManager: 171 files.
  • Every other test file that mentions linking or update checks: 22 files, 879 tests passed. Three browser-mode files couldn't start because Playwright's Chromium isn't installed on ASUS. None of them reads either setting.
  • Linking and update-check server tests (PeerLinks, RemoteDelegation, McpOAuth, McpHttpServer, ModelManifest, ClaudeMaintenance, PeerLinkRequests, PeerForwarding, theme): they pass after the test updates above.
  • @t3tools/contracts typecheck: 0 errors. vp fmt --check and lint are clean on the changed files.
  • I committed with --no-verify. The pre-commit hook's format and lint steps pass, but its knip:check fails on the base branch: 4 files left unused after the upstream workflows were removed (.github/scripts/mirror-play-apk.cjs, apps/web/scripts/verify-built-boot.ts, scripts/resolve-nightly-release.ts, scripts/smoke-cli-archive.ts). This diff doesn't touch them, and the fork's CI doesn't run knip.
  • After rebasing onto 47007e11f4, which includes feat(inbox): agent-launched threads go to Agents unless the agent picks an inbox #72: budget, ProviderSessionManager, McpHttpServer, ModelManifest, contracts settings and shared settings tests all pass (6 files, 209 tests). git range-diff shows the only change is dropping the budget edit.
  • One independent review round, by a separate Claude Opus 5.5 reviewer, is summarized in a comment below.

Model: claude-opus-5-5
Task: implementation

🤖 Generated with Claude Code

@nullStack65
nullStack65 force-pushed the feat/closura-opinionated-defaults branch from 4365a54 to 2b48708 Compare November 18, 2026 11:29
@nullStack65

Copy link
Copy Markdown
Owner Author

Independent review: the one bot round for this PR. Reviewer: a separate Claude Opus 5.5 subagent. It read range 2d4987ee27..4365a54e4c read-only. This is an automated technical review, not a human approval.

Result: no blockers. Linked environments on by default doesn't weaken linking auth: the setting only adds refusals, and approval still needs a pairing code, or a session holding access:write plus a CSRF token. The reviewer found nothing hardcoding the old defaults. The edited tests still test what their names say, and this is the smallest sufficient change.

What came out of it:

  1. Should-fix (description). The upgrade claim was wrong. Defaults are stripped on write, so machines take the new defaults unless a value written by hand differs from them. Fixed in the description.
  2. Should-fix (description and docs). Turning update checks off also stops the model catalog download. Now stated in the description and in docs/user/updating.md (commit f78fcc3).
  3. Nit. The budget increase wasn't caused by this change. I checked it myself: with the base defaults restored, the budget test measures 51965 bytes and passes. The value was already stale on the base branch, so I reworded the commit message (2b48708).
  4. Nit. The test accounting in the description was out of date. Updated.
  5. Nit, not taken. theme.test.ts uses enableProviderUpdateChecks: false, which now equals the default. The test still catches a dropped key.
  6. Nit, noted. Stock clients' "reset to default" applies stock defaults and saves them explicitly.

Head after fixes: f78fcc35d6.

@nullStack65 nullStack65 reopened this Nov 18, 2026
nullStack65 and others added 3 commits November 18, 2026 11:52
…updates

Closura machines link to each other and pin their provider CLIs, but every
new install started with Linked environments off, so links and link cards were
refused, and with stock provider update checks on. Fleet machines had both set
by hand.

Make them built-in defaults: Linked environments on, provider update checks
off. A machine that already stored a value keeps it. Two tests that relied on
the old defaults now set them explicitly.

Model: claude-opus-5-5
Task: implementation
Agent: Builder

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…d tests

These tests flip Linked environments to show that a change reloads tools;
with the setting on by default they now flip it off.

Model: claude-opus-5-5
Task: fix
Agent: Builder

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
They also gate the model catalog download, so say where to turn them on.

Model: claude-opus-5-5
Task: docs
Agent: Builder

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@nullStack65
nullStack65 force-pushed the feat/closura-opinionated-defaults branch from f78fcc3 to f3a4bb2 Compare November 18, 2026 11:55
@nullStack65
nullStack65 merged commit c540875 into release/native-0.1.10 Nov 18, 2026
2 checks passed
@nullStack65

Copy link
Copy Markdown
Owner Author

Build artifacts from the merge commit c540875353 (built on ASUS, not installed anywhere yet)

Artifact Path on ASUS sha256 Checks
Linux x64 desktop AppImage ~/.local/share/closura/t3-release-staging/closura-defaults-desktop-0.1.10-c5408753/T3-Code-0.1.10-x86_64.AppImage ac14932aef4400c9fc0c435f1d24207a82bd8fed837f9e37a556419f50958264 Fork recipe scripts/closura/build-linux-desktop-noble.sh --build-version 0.1.10 --provide-build-tools. All qualify-desktop-app.py gates pass (manifest.json). No app-update.yml, so it never auto-updates to stock. Bundled server reports 0.1.10 and decodes linkedEnvironmentsEnabled → true and enableProviderUpdateChecks → false.
Linux x64 desktop .deb same folder, T3-Code-0.1.10-amd64.deb 36a69fe30a7177082c7a9f047d3fa3f15822c249fef2c0450627deccd2e25791 Same build.
Linux x64 headless server (t3 serve, what ASUS and R720 run) ~/.local/share/closura/t3-release-staging/closura-defaults-server-0.1.10-c5408753/t3-0.1.10-linux-x64.tar.gz 461de77e1fbec93e985d53d8969406a0de13be44165b5d334103cb165b4b1f96 scripts/smoke-cli-archive.ts --expect-version 0.1.10 passes (--version, service launcher, serve) in a scratch home. Max GLIBC 2.34. Build steps are in manifest.json.

macOS: blocked, not built. scripts/closura/build-mac-arm64-desktop.sh must run on an Apple Silicon Mac. Jeff's Air is the only one, and it answered "No route to host" at 10:15Z today. The laptop is Intel and is off-limits for builds, and the fork has no Intel macOS recipe.

  • To clear it: once the Air is reachable, run this from a checkout of c540875353 that has vp install done:
    scripts/closura/build-mac-arm64-desktop.sh --work ~/t3w --output-dir ~/t3out --build-version 0.1.10
  • That script checks its own output: version, bundle id, arm64, signature, and that the server and web bundles match the Linux build.

Install notes for the fleet rollout:

  • The Linux desktop app is a self-contained AppImage. Replace the stock app with it, or install the .deb.
  • Headless servers: unpack the tarball, then point the service at t3-0.1.10-linux-x64/t3 serve ..., the same layout the CLO-866 stage used.
  • New defaults only reach machines that never stored the old value:
    • A machine with linkedEnvironmentsEnabled: false written by hand keeps it, so set it on that machine.
    • A machine where someone turned Require approval for new devices on keeps it. It's in Settings → Sharing & access, its search terms include "pairing code", and it makes a connecting device wait for approval and show a verification code. It's most likely what blocked Jeff's Air. Turn it off there; the default is already off.
  • Stock auto-update: none of these builds embed an update feed. The server never updates itself, but a person can still click a manual stock "Update". Uninstalling stock T3 removes the stock updater.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant