Repository navigation
fix(web): show the sidebar filter tint when filters change - #163
Open
nullStack65 wants to merge 1 commit into
Open
nullStack65 wants to merge 1 commit into
nullStack65 wants to merge 1 commit into
Conversation
The filter button no longer draws an unread-style dot, and it sets text-primary on the sliders icon when the filter differs from the default. SidebarMenuButton paints direct svg children with the sidebar icon color, and that rule beats a plain text-primary, so the changed filter had no visible mark. The icon now uses an important primary color. Model: grok-4.7 Task: fix Agent: Platform Harness: t3
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
Owner
Author
|
Frozen 2026-11-22 CEO portfolio audit — cash-path priority; can reopen at the Dec 18 runway check. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sidebar filter button stopped drawing an unread-style dot and was supposed to tint the sliders icon when the filter differs from the default. The tint never painted.
SidebarMenuButtonsets[&>svg]:text-[var(--sidebar-icon-color)], and that rule beatstext-primaryon the icon. At rest the icon stayed the sidebar icon color. On hover it turned the sidebar foreground color. A changed filter had no visible mark.The icon now uses
text-primary!, which wins over that rule. The default filter stays the ordinary icon color.Pinned threads still stay in Pinned while they work.
resolveSidebarShelfmoves only unpinned active threads into Working. The hover card still names the sender throughthreadSenderLine. Standing bots still render above the pinned list.Evidence
text-primaryinside a button that sets[&>svg]:text-[var(--sidebar-icon-color)]computedrgb(1, 2, 3)at rest andrgb(17, 17, 17)on hover. The same svg withtext-primary!computedrgb(124, 58, 237).pnpm exec vp test run apps/web/src/components/sidebar/threadListFilter.logic.test.tspassed, 7 tests, on Node v26.13.1.vp fmtandvp linton the three files passed.vp run knip:check:exportslists 24 unused exports already onrelease/native-0.1.10. None are in this diff. The pre-commit hook runs that check, so the commit used--no-verify.scripts/repair_attempt_guard.pyis not in this checkout.The desktop sidebar was not opened. Pinned placement and the hover-card sender line were confirmed in source and existing tests, not in a running app.
Model: grok-4.7
Task: fix
Agent: Platform
Harness: t3
Deploy: none