Skip to content

perf(ci): run the ARC voice and inbox check as parallel cached jobs - #151

Merged
nullStack65 merged 4 commits into
release/native-0.1.10from
perf/arc-ci-parallel-cache
Nov 21, 2026
Merged

nullStack65 merged 4 commits into
release/native-0.1.10from
perf/arc-ci-parallel-cache

Conversation

@nullStack65

Copy link
Copy Markdown
Owner

Problem

The required ARC check Voice + founder inbox (Linux ARC) ran every typecheck, all 48 tests and both builds as one serial job with caching switched off. Recent runs on release/native-0.1.10 took 11 to 15 minutes (for example run 44807747792 took 14m42s), and the single self-hosted runner queued the next run behind it.

Fix

The job splits into three workers that run at the same time on t3code-ci-arc: core (typecheck, server tests, server build), web (web tests and the web build) and mobile (mobile tests and the Playwright voice latency test). A small aggregator job keeps the exact name Voice + founder inbox (Linux ARC) that the release-native-protection ruleset requires, and it fails unless all three workers succeeded. It does not run when the workflow was cancelled, so a run that gets cancelled while its workers are still queued cannot report the required check green.

Dependencies install through the existing .github/actions/setup-ci-deps action, which caches the Vite+ home, the pnpm store and the lockfile verification record with actions/cache. The Playwright Chromium shell gets its own cache keyed on the lockfile. Only the core job saves the pnpm store, so the three jobs do not race to reserve one key. The store save keeps the action's original condition: the push to the default branch, which on this fork is release/native-0.1.10, writes the store every later run reads.

.github/scripts/arc-ci-coverage.cjs fails the required check if a worker stops running one of the 48 tests the serial job ran, or if the aggregator would run on a cancelled workflow. node --test .github/scripts/arc-ci-coverage.test.cjs passes, 4 of 4, and actionlint reports no findings once the self-hosted runner label is configured.

Review

One independent review round on grok/grok-4.7 returned two Important findings: the aggregator ran on cancellation, and the widened pnpm store save wrote a cache only one pull request could read. Both are fixed in 61b4730db8 and sent back for a focused re-check of those two findings only.

Deploy: none

Model: grok/grok-4.7
Task: implementation

The single Voice + founder inbox job ran every typecheck, test and both
builds on one runner with caching off, so each run took 11-15 minutes and
queued behind itself. Split it into core, web and mobile workers that run
together, and keep the required check name on a small aggregator that fails
unless all three succeeded. Dependencies now install through the shared
cache action, the Playwright browser is cached, and a release-branch push
or pull request can save the pnpm store instead of only the stale default
branch.

Model: grok/grok-4.7
Task: implementation
Agent: Builder
Lane: magpie
Harness: t3
The aggregator used if: always(), which also runs when the workflow is
cancelled, and a worker that never started reports success. A new push
cancels the previous run, so the required check would have gone green for a
run whose tests never started. It now runs only when the workflow was not
cancelled, and the coverage guard rejects both that condition and a test
path that only appears inside dead code.

The pnpm store save goes back to the action's original condition. This
fork's default branch is release/native-0.1.10, so the push to it already
writes the store every later run reads, and a pull request cache would only
have been readable by that one PR.

Model: grok/grok-4.7
Task: fix
Agent: Builder
Lane: magpie
Harness: t3
@coderabbitai

coderabbitai Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@nullStack65

Copy link
Copy Markdown
Owner Author
{
  "reviewed_head": "6334976e4832deb6d454b7d0f176a0f47d87fc7f",
  "reviewer": "grok/grok-4.7",
  "findings": [
    {
      "id": "aggregator-runs-on-cancellation",
      "severity": "important",
      "summary": "The aggregator used if: always(), so a cancelled run whose workers never started reported the required check green.",
      "outcome": "confirmed",
      "rechecked_head": "61b4730db8a52dd369523d33757f3d89467124bc"
    },
    {
      "id": "pr-scoped-pnpm-store-save",
      "severity": "important",
      "summary": "Widening the pnpm store save to pull requests wrote a cache only that one PR could read. The default branch is release/native-0.1.10, so the original push-to-default condition already writes the shared store.",
      "outcome": "confirmed",
      "rechecked_head": "61b4730db8a52dd369523d33757f3d89467124bc"
    }
  ]
}

Focused re-check of both findings on 61b4730db8a52dd369523d33757f3d89467124bc returned FIXED for each. The aggregator is now if: ${{ !cancelled() }}, the coverage guard rejects a cancelled-run condition and a test path that only appears in dead code, and the pnpm store save is back to the push-to-default-branch condition.

…/arc-ci-parallel-cache

Keep the fork drift receipt from #147 and the three cached ARC workers
from this branch. The receipt runs on the core worker after setup-ci-deps
provides Node, and it still unshallows the shallow checkout before it
measures history.

Model: grok/grok-4.7
Task: conflict
Agent: Builder
Lane: magpie
Harness: t3
@nullStack65

Copy link
Copy Markdown
Owner Author

Note

🤖 Grok 4.7 responding on behalf of nullStack65

Resolved the merge conflict with release/native-0.1.10 on perf/arc-ci-parallel-cache. Head 716912287ee31d328fcf64edcfa46b27f1e0df0f.

The core worker still installs through setup-ci-deps and is the job that saves the store. The fork drift receipt from the fork sync change (t3code#147, CLO-967) runs on that worker after Node is available, and it still unshallows the shallow checkout before it measures history. The web and mobile workers keep their cached installs.

Verified on that head before push: YAML safe_load of .github/workflows/closura-arc-ci.yml passed; node --test scripts/fork-drift-receipt.test.mjs passed 3; node --test .github/scripts/arc-ci-coverage.test.cjs passed 4. GitHub Actions on the new head were not watched. This does not merge the pull request.

The founder-inbox job checked out only .github and ran the coverage
script with node, but the ARC image has no node on PATH, so the step
exited 127. Provide libatomic, then setup-node from package.json,
before that script. The guard fails if that order is removed.

Model: grok-4.7
Task: fix
Agent: Builder
Lane: grok
Harness: t3
@nullStack65
nullStack65 merged commit 8c869b4 into release/native-0.1.10 Nov 21, 2026
6 checks passed
@nullStack65
nullStack65 deleted the perf/arc-ci-parallel-cache branch November 21, 2026 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant