Repository navigation
fix(web): show linked environments as connected and clear their Failed pill - #150
Merged
Merged
Conversation
…d pill A server-linked environment is reachable but has no catalog connection, so the Environments filter painted it gray forever. A listed link is reachable by construction, so the filter now treats it as connected. Linked thread shells carried no visit time, so a failed run looked unseen even after the host was visited or finished. The thread list now forwards the host's lastVisitedAt and the shell uses it. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
The linked shell dated a failed run by updatedAt, so a rename or settle after the visit looked like a new failure. The list now carries the run's own completion time. A visit that changes nothing else was also dropped, because the sidebar compared threads without their visit time. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On a machine that only reaches another environment through a server link, the sidebar Environments filter showed a gray dot for that environment even while
t3 environment listreported it reachable with live threads. Threads on that link also stayed on the Failed pill long after the host had completed them or the user had seen the failure.A server link is reachable by the time the sidebar lists it, but it has no connection in the client catalog, and the filter only paints green for a catalog connection. The linked thread list also dropped the host's visit time, so every failed run looked unseen.
Change
The filter treats an environment the linked sidebar lists as connected, alongside catalog connections. The thread list item now carries
lastVisitedAt, optional so an older peer that omits it still decodes, and the linked sidebar copies it into the rebuilt thread shell. A failure the user has not seen still shows Failed; a later visit or a completed run clears it.Scope
Bug fix for the linked-environment sidebar added by the linked-environment threads issue (CLO-963, pull request 133). Tracked on the sidebar stale-state issue (CLO-1037).
Verification
packages/client-runtimesrc/state/linkedSidebar.test.ts: 4 passed. A failed linked thread stays unseen until the host records a later visit, and a completed linked thread drops the Failed pill.apps/serversrc/peer/linkedSidebar.test.ts: 1 passed. The collector forwards the host'slastVisitedAt.apps/websrc/state/linkedSidebar.test.ts: 3 passed. A server-only link is reported for the filter dot.effect-tsgotypecheck passed with no errors forpackages/contracts,packages/client-runtime, andapps/server.apps/webhas no typecheck script.Deploy: none
Agent: grok/grok-4.7 through the Claude Code harness.