Repository navigation
fix(web): sidebar filter counts include settled threads from server totals - #135
Merged
Merged
Conversation
…otals The filter menu counted only loaded, unsettled threads, so rows read about 10 while each server held hundreds. Count settled threads too, using the servers' older-settled groups for threads the shell did not send, and say which threads the counts leave out: unclassified threads the default inbox filter hides, and delegated or subagent threads that open from their parent. Model: claude-opus-5-5 Task: fix Agent: claude-code Lane: CLO-969 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
Count loaded delegated rows the same way the servers' older-settled groups do, mark settled counts as minimums when a server sends totals without groups, and move the older-settled grouping into the tested filter logic. Model: claude-opus-5-5 Task: fix Agent: claude-code Lane: CLO-969 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
Author
|
Review round (one independent bot review, Claude Fable 5.2 via the Magpie Codex instance; the Grok provider instance is disabled on ASUS) on head 5a48695, fixed at e5d099e:
Tests: threadListFilter.logic.test.ts 6 passed. apps/web typecheck passed. Lint and format clean. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kameron's sidebar showed about 270 threads and filter rows of about 10, while hosts reported about 960 live threads.
Most of that gap is not a load cap. Counting top-level threads only, the hosts hold about 303 (r720 114, asus 72, mac-laptop 58, JS Air 35, omarcy 24). The rest are delegated and subagent children, which open from their parent thread. The
t3_thread_listtool counts those children by default. Settled top-level threads were already reachable: the shell sends the 25 newest per environment, and the Settled shelf pages the rest with server totals ("Show more").The real defect was the filter menu. Its counts covered only loaded, unsettled threads in working, done and needs-me buckets, so each row read about 10 and skipped every settled thread.
This PR:
olderSettled.counts[].groups, already on the wire) for threads the shell did not send. Loaded rows below the cut are not double-counted, and the filter facets still apply.No server or contract change.
Model: claude-opus-5-5
Task: fix
Agent: claude-code (CLO-969)
Harness: t3/claude
Requirement: https://linear.app/closura/issue/CLO-969/t3-sidebar-drops-most-threads-pagelimit-cap
Human review: not requested
Verified:
vp test run apps/web/src/components/sidebar/threadListFilter.logic.test.ts(6 passed, including a new case forolderSettledFilterCounts: project scope, servers without groups, loaded rows below the cut skipped, unclassified counted).vp run typecheckinapps/webpassed. Lint and format of the changed files passed.Unverified: not driven in a real client. Servers that send counts without
groups(older builds) still show only the loaded settled rows. Linked-environment threads proxied throughpeer/linkedSidebar.tsare listed up to 8 pages of 100, and pages after a slow one (3 s budget) are dropped silently. That is not changed here.Deploy: fleet
🤖 Generated with Claude Code