Skip to content

fix(web): sidebar filter counts include settled threads from server totals - #135

Merged
nullStack65 merged 2 commits into
release/native-0.1.10from
fix/sidebar-thread-cap
Nov 20, 2026
Merged

nullStack65 merged 2 commits into
release/native-0.1.10from
fix/sidebar-thread-cap

Conversation

@nullStack65

@nullStack65 nullStack65 commented Nov 20, 2026 •

Copy link
Copy Markdown
Owner

Kameron's sidebar showed about 270 threads and filter rows of about 10, while hosts reported about 960 live threads.

Most of that gap is not a load cap. Counting top-level threads only, the hosts hold about 303 (r720 114, asus 72, mac-laptop 58, JS Air 35, omarcy 24). The rest are delegated and subagent children, which open from their parent thread. The t3_thread_list tool counts those children by default. Settled top-level threads were already reachable: the shell sends the 25 newest per environment, and the Settled shelf pages the rest with server totals ("Show more").

The real defect was the filter menu. Its counts covered only loaded, unsettled threads in working, done and needs-me buckets, so each row read about 10 and skipped every settled thread.

This PR:

  • Adds a settled column to each Inbox, From and Environment row. It counts loaded settled threads plus the servers' older-settled groups (olderSettled.counts[].groups, already on the wire) for threads the shell did not send. Loaded rows below the cut are not double-counted, and the filter facets still apply.
  • Adds a visible note naming what the counts leave out. Subagent threads open from their parent and are not counted. Threads with no inbox appear only with every inbox checked; the default founder filter (owner plus Agents) hides them, and the note gives their number. When a server sends settled totals without the inbox breakdown, the note says settled counts are minimums.

No server or contract change.

Model: claude-opus-5-5
Task: fix
Agent: claude-code (CLO-969)
Harness: t3/claude
Requirement: https://linear.app/closura/issue/CLO-969/t3-sidebar-drops-most-threads-pagelimit-cap
Human review: not requested

Verified: vp test run apps/web/src/components/sidebar/threadListFilter.logic.test.ts (6 passed, including a new case for olderSettledFilterCounts: project scope, servers without groups, loaded rows below the cut skipped, unclassified counted). vp run typecheck in apps/web passed. Lint and format of the changed files passed.

Unverified: not driven in a real client. Servers that send counts without groups (older builds) still show only the loaded settled rows. Linked-environment threads proxied through peer/linkedSidebar.ts are listed up to 8 pages of 100, and pages after a slow one (3 s budget) are dropped silently. That is not changed here.

Deploy: fleet

🤖 Generated with Claude Code

…otals

The filter menu counted only loaded, unsettled threads, so rows read about 10
while each server held hundreds. Count settled threads too, using the servers'
older-settled groups for threads the shell did not send, and say which threads
the counts leave out: unclassified threads the default inbox filter hides, and
delegated or subagent threads that open from their parent.

Model: claude-opus-5-5
Task: fix
Agent: claude-code
Lane: CLO-969

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Count loaded delegated rows the same way the servers' older-settled groups do,
mark settled counts as minimums when a server sends totals without groups,
and move the older-settled grouping into the tested filter logic.

Model: claude-opus-5-5
Task: fix
Agent: claude-code
Lane: CLO-969

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@nullStack65

Copy link
Copy Markdown
Owner Author

Review round (one independent bot review, Claude Fable 5.2 via the Magpie Codex instance; the Grok provider instance is disabled on ASUS) on head 5a48695, fixed at e5d099e:

  1. Medium, fixed: older delegated tasks were counted through the server groups while loaded delegated rows were dropped. Loaded delegated rows are now counted too, so both sides agree, and the note now says only subagent threads are left out.
  2. Low, fixed: servers that send totals without groups undercounted silently. The menu now says settled counts are minimums when that happens.
  3. Low, not changed: the settled column is a state count, so it includes pinned and snoozed settled rows the Settled shelf leaves out. The two numbers are not meant to match.
  4. Low, fixed: removed the callback-carrying generic. olderSettledFilterCounts now lives in threadListFilter.logic.ts with a test covering scope, missing groups and covers.
  5. Nit, fixed: the note is shorter.

Tests: threadListFilter.logic.test.ts 6 passed. apps/web typecheck passed. Lint and format clean.

@nullStack65
nullStack65 merged commit 159345f into release/native-0.1.10 Nov 20, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant