Repository navigation
fix(server): full-access Codex threads no longer wait on approval - #134
Merged
nullStack65 merged 1 commit intoNov 20, 2026
Merged
Conversation
Codex still asks for rm, kill, and sudo under the granular full-access policy because that policy keeps dangerous-command prompts. Those three requestApproval handlers now accept at once and write no runtime request. Narrower modes still wait. Model: grok-4.7 Task: CLO-962 Agent: Codex Lane: magpie Harness: t3/codex Model-family: Grok Model-generation: 4.7 Skills-SHA: de3fb55970ecd0672d321d45360bc13d187b9bda2b601bfe75d3bd9c4f5c2888 Co-Authored-By: Codex <noreply@openai.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Full-access Codex threads were stopping on approval cards for
rm,kill, andsudo. The live turn does not sendapprovalPolicy: "never".codexRuntimeModeTurnDefaultssends a granular policy withsandbox_approval: falseso browser and app prompts still reach T3. Codex then still prompts for a dangerous command:allow_dangerous_command_prompttreats that granular policy as a prompt instead of a rejection. Sendingneverwould forbid those commands (AskForApproval::Neverreturns Forbidden), so the policy stays. In full access,item/commandExecution/requestApproval,item/fileChange/requestApproval, anditem/permissions/requestApprovalnow answer accept immediately and write no runtime request. Approval-required threads still park them. A request opened under a narrower mode is not answered later just because a following turn is full access.Deploy: none
Model: grok-4.7
Task: CLO-962
Harness: t3/codex