Skip to content

fix(server): full-access Codex threads no longer wait on approval - #134

Merged
nullStack65 merged 1 commit into
release/native-0.1.10from
t3/fix-codex-full-access-approvals
Nov 20, 2026
Merged

nullStack65 merged 1 commit into
release/native-0.1.10from
t3/fix-codex-full-access-approvals

Conversation

@nullStack65

Copy link
Copy Markdown
Owner

Full-access Codex threads were stopping on approval cards for rm, kill, and sudo. The live turn does not send approvalPolicy: "never". codexRuntimeModeTurnDefaults sends a granular policy with sandbox_approval: false so browser and app prompts still reach T3. Codex then still prompts for a dangerous command: allow_dangerous_command_prompt treats that granular policy as a prompt instead of a rejection. Sending never would forbid those commands (AskForApproval::Never returns Forbidden), so the policy stays. In full access, item/commandExecution/requestApproval, item/fileChange/requestApproval, and item/permissions/requestApproval now answer accept immediately and write no runtime request. Approval-required threads still park them. A request opened under a narrower mode is not answered later just because a following turn is full access.

Deploy: none

Model: grok-4.7
Task: CLO-962
Harness: t3/codex

Codex still asks for rm, kill, and sudo under the granular full-access
policy because that policy keeps dangerous-command prompts. Those three
requestApproval handlers now accept at once and write no runtime request.
Narrower modes still wait.

Model: grok-4.7
Task: CLO-962
Agent: Codex
Lane: magpie
Harness: t3/codex
Model-family: Grok
Model-generation: 4.7
Skills-SHA: de3fb55970ecd0672d321d45360bc13d187b9bda2b601bfe75d3bd9c4f5c2888
Co-Authored-By: Codex <noreply@openai.com>
@coderabbitai

coderabbitai Bot commented Nov 20, 2026

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@nullStack65
nullStack65 merged commit c68ad0f into release/native-0.1.10 Nov 20, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant