Skip to content

fix(server): full-access Claude threads no longer wait on approval - #132

Merged
nullStack65 merged 2 commits into
release/native-0.1.10from
t3/fix-full-access-approval-prompts
Nov 20, 2026
Merged

nullStack65 merged 2 commits into
release/native-0.1.10from
t3/fix-full-access-approval-prompts

Conversation

@nullStack65

@nullStack65 nullStack65 commented Nov 20, 2026 •

Copy link
Copy Markdown
Owner

Full-access Claude threads were stopping on approval cards. A workspace that sets permissions.disableBypassPermissionsMode to disable made T3 downgrade full access to Claude's auto mode, and the permission callback then waited, including for an ask rule such as gh pr merge.

Full access now runs that command instead of waiting. Claude's removal check and a permission-rule denial still fail immediately with an error, and approval-required threads still wait.

A full-access thread is one whose runtime policy maps to Claude bypassPermissions. An explicit approval policy, plan mode, or a read-only policy still asks, which keeps replay fixtures on the approval path. When bypass is disabled in Claude settings, full access still does not wait: an ask rule or an unrecognised safety prompt is allowed, and only the removal check and a matched deny rule fail the command. That is intentional. A full-access thread must not sit on an approval card, so disableBypassPermissionsMode no longer makes those threads wait.

Deploy: none

Model: grok-4.7
Harness: t3/codex

A full-access thread whose workspace disables Claude bypass was downgraded
to auto mode and then sat on the permission callback, including an ask
rule for gh pr merge. Full access now runs the command. Claude's removal
check and a permission-rule denial still fail immediately, and
approval-required threads still wait.

Model: grok-4.7
Task: CLO-962
Agent: Codex
Lane: magpie
Harness: t3/codex
Model-family: Grok
Model-generation: 4.7
Skills-SHA: de3fb55970ecd0672d321d45360bc13d187b9bda2b601bfe75d3bd9c4f5c2888
Co-Authored-By: Codex <noreply@openai.com>
@coderabbitai

coderabbitai Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Replay threads keep a full-access runtime mode and set an approval
policy. Treating every full-access mode as bypass auto-allowed those
tools, so the harness waited forever for a request. Full access now
means permissionModeForClaudeRuntimePolicy returns bypassPermissions,
the same predicate as the downgrade notice. Plan mode, an explicit
approval policy, and a read-only never policy still ask. Removal
checks and deny rules still fail immediately.

Model: grok-4.7
Task: CLO-962
Agent: Codex
Lane: magpie
Harness: t3/codex
Model-family: Grok
Model-generation: 4.7
Skills-SHA: de3fb55970ecd0672d321d45360bc13d187b9bda2b601bfe75d3bd9c4f5c2888
Co-Authored-By: Codex <noreply@openai.com>
@nullStack65
nullStack65 merged commit dd9eb33 into release/native-0.1.10 Nov 20, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant