Repository navigation
fix(server): full-access Claude threads no longer wait on approval - #132
Merged
nullStack65 merged 2 commits intoNov 20, 2026
Merged
Conversation
A full-access thread whose workspace disables Claude bypass was downgraded to auto mode and then sat on the permission callback, including an ask rule for gh pr merge. Full access now runs the command. Claude's removal check and a permission-rule denial still fail immediately, and approval-required threads still wait. Model: grok-4.7 Task: CLO-962 Agent: Codex Lane: magpie Harness: t3/codex Model-family: Grok Model-generation: 4.7 Skills-SHA: de3fb55970ecd0672d321d45360bc13d187b9bda2b601bfe75d3bd9c4f5c2888 Co-Authored-By: Codex <noreply@openai.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
Replay threads keep a full-access runtime mode and set an approval policy. Treating every full-access mode as bypass auto-allowed those tools, so the harness waited forever for a request. Full access now means permissionModeForClaudeRuntimePolicy returns bypassPermissions, the same predicate as the downgrade notice. Plan mode, an explicit approval policy, and a read-only never policy still ask. Removal checks and deny rules still fail immediately. Model: grok-4.7 Task: CLO-962 Agent: Codex Lane: magpie Harness: t3/codex Model-family: Grok Model-generation: 4.7 Skills-SHA: de3fb55970ecd0672d321d45360bc13d187b9bda2b601bfe75d3bd9c4f5c2888 Co-Authored-By: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Full-access Claude threads were stopping on approval cards. A workspace that sets
permissions.disableBypassPermissionsModetodisablemade T3 downgrade full access to Claude'sautomode, and the permission callback then waited, including for an ask rule such asgh pr merge.Full access now runs that command instead of waiting. Claude's removal check and a permission-rule denial still fail immediately with an error, and approval-required threads still wait.
A full-access thread is one whose runtime policy maps to Claude
bypassPermissions. An explicit approval policy, plan mode, or a read-only policy still asks, which keeps replay fixtures on the approval path. When bypass is disabled in Claude settings, full access still does not wait: an ask rule or an unrecognised safety prompt is allowed, and only the removal check and a matched deny rule fail the command. That is intentional. A full-access thread must not sit on an approval card, sodisableBypassPermissionsModeno longer makes those threads wait.Deploy: none
Model: grok-4.7
Harness: t3/codex