Repository navigation
fix(composer): keep a supported effort when the model changes - #130
Merged
nullStack65 merged 2 commits intoNov 20, 2026
Merged
Conversation
The composer already sets model and reasoning from one control. A different model dropped that effort unless the model had a remembered choice. The next model now keeps the current effort when it offers that level, and otherwise uses its own default. Model: grok-4.7 Task: fix Agent: CLO-848 Lane: magpie Harness: t3/codex Model-family: Grok Model-generation: 4.7 Skills-SHA: 0540352af0d6f43bdeea39a8c4aad4660ab0ec55 Co-Authored-By: Grok 4.7 <noreply@x.ai>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
Owner
Author
|
Review request is the one bot round for this pull request. Head 1640517. |
A reasoning id was dropped before its descriptor was read, so a boolean thinking toggle the next model offers was cleared on every switch. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Owner
Author
{"reviewed_head":"1640517fafcdc5ec640759766dcdf45f51b147ff","reviewer":"grok-4.7-build (claudeAgent, read-only)","findings":[{"id":"thinking-boolean-dropped","severity":"important","summary":"optionsForModelSwitch treated every reasoning id as a carried select before reading its descriptor, so a boolean thinking toggle the next model offers was cleared on every model switch.","outcome":"confirmed","rechecked_head":"1a29ba3a156467060d13450c4d3de89a48600551"}]} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The composer already sets the model and its reasoning effort from one control. Choosing a different model dropped that effort unless the model already had a remembered choice.
Switching models now keeps the current effort when the next model offers it, and otherwise leaves that model's own default. The effort list is still the selected model's options. Nothing new is stored.
Deploy: fleet
Model: grok-4.7
Task: fix
Agent: CLO-848
Lane: magpie
Harness: t3/codex
Model-family: Grok
Model-generation: 4.7
Skills-SHA: 0540352af0d6f43bdeea39a8c4aad4660ab0ec55