Skip to content

fix(composer): keep a supported effort when the model changes - #130

Merged
nullStack65 merged 2 commits into
release/native-0.1.10from
t3/composer-model-effort-picker
Nov 20, 2026
Merged

nullStack65 merged 2 commits into
release/native-0.1.10from
t3/composer-model-effort-picker

Conversation

@nullStack65

@nullStack65 nullStack65 commented Nov 20, 2026 •

Copy link
Copy Markdown
Owner

The composer already sets the model and its reasoning effort from one control. Choosing a different model dropped that effort unless the model already had a remembered choice.

Switching models now keeps the current effort when the next model offers it, and otherwise leaves that model's own default. The effort list is still the selected model's options. Nothing new is stored.

Deploy: fleet

Model: grok-4.7
Task: fix
Agent: CLO-848
Lane: magpie
Harness: t3/codex
Model-family: Grok
Model-generation: 4.7
Skills-SHA: 0540352af0d6f43bdeea39a8c4aad4660ab0ec55

The composer already sets model and reasoning from one control. A different
model dropped that effort unless the model had a remembered choice. The next
model now keeps the current effort when it offers that level, and otherwise
uses its own default.

Model: grok-4.7
Task: fix
Agent: CLO-848
Lane: magpie
Harness: t3/codex
Model-family: Grok
Model-generation: 4.7
Skills-SHA: 0540352af0d6f43bdeea39a8c4aad4660ab0ec55
Co-Authored-By: Grok 4.7 <noreply@x.ai>
@coderabbitai

coderabbitai Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@nullStack65

Copy link
Copy Markdown
Owner Author

Review request is the one bot round for this pull request. Head 1640517.

A reasoning id was dropped before its descriptor was read, so a boolean
thinking toggle the next model offers was cleared on every switch.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@nullStack65

Copy link
Copy Markdown
Owner Author
{"reviewed_head":"1640517fafcdc5ec640759766dcdf45f51b147ff","reviewer":"grok-4.7-build (claudeAgent, read-only)","findings":[{"id":"thinking-boolean-dropped","severity":"important","summary":"optionsForModelSwitch treated every reasoning id as a carried select before reading its descriptor, so a boolean thinking toggle the next model offers was cleared on every model switch.","outcome":"confirmed","rechecked_head":"1a29ba3a156467060d13450c4d3de89a48600551"}]}

@nullStack65
nullStack65 merged commit 11585a6 into release/native-0.1.10 Nov 20, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant