Skip to content

fix(server): reject a model the provider instance does not serve - #129

Merged
nullStack65 merged 2 commits into
release/native-0.1.10from
fix/clo-946-provider-model-guard
Nov 20, 2026
Merged

nullStack65 merged 2 commits into
release/native-0.1.10from
fix/clo-946-provider-model-guard

Conversation

@nullStack65

Copy link
Copy Markdown
Owner

A launch with provider instance claudeAgent and model grok/grok-4.7 was accepted and ran as grok-4.7-build on the Claude harness. Thread launch, delegate task, thread configure, sends that change the model, scheduled-task saves, and dispatch now share one catalog check. A model the instance does not list is rejected before a run starts, and the error names that instance and the models it serves.

Model: grok-4.7
Task: CLO-946 refuse a model the provider instance does not serve

Deploy: fleet

A launch with claudeAgent and grok/grok-4.7 was accepted and ran on the Claude harness. Paths that start work now check that instance's catalog and name the models it serves.

Model: grok-4.7
Task: CLO-946 refuse a model the provider instance does not serve
Agent: magpie
Lane: magpie
Harness: t3/codex
Model-family: Grok
Model-generation: 4.7
Skills-SHA: 0540352af0d6f43bdeea39a8c4aad4660ab0ec55
Co-Authored-By: Grok 4.7 <noreply@x.ai>
@coderabbitai

coderabbitai Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

A custom-only Codex catalog no longer refuses built-in models, and launch, send, and schedule paths fail the check when the registry is missing instead of skipping it.

Model: grok-4.7
Task: CLO-946 refuse a model the provider instance does not serve
Agent: magpie
Lane: magpie
Harness: t3/codex
Model-family: Grok
Model-generation: 4.7
Skills-SHA: 0540352af0d6f43bdeea39a8c4aad4660ab0ec55
Co-Authored-By: Grok 4.7 <noreply@x.ai>
@nullStack65

Copy link
Copy Markdown
Owner Author

Local stand-in for "Voice + founder inbox (Linux ARC)" on 7524505.

The check is still pending. All three t3code-ci-arc runners are offline, so this is the CLO-694 case. I did not restart runners and did not merge.

The workflow's root vp test run fails on the machine Node 22.22.1 because the web Vite config cannot load a .ts import (ERR_UNKNOWN_FILE_EXTENSION on packages/shared/src/devProxy.ts). I reran the test, mobile, and build steps with the workflow's pinned Node 26.13.1 (/home/primary/.local/share/vite-plus/js_runtime/node/26.13.1). Typecheck ran first on Node 22 and passed; I did not repeat it on Node 26.

  • AssemblyAI voice + shared founder inbox source guard: pass
  • vp run --filter typecheck for contracts, shared, client-runtime, provider-core, t3, and mobile: pass
  • Workflow server/web/contracts test list on Node 26: 27 files, 696 tests, pass
  • Mobile placement/outbox/upload list on Node 26: 15 files, 290 tests, pass
  • vp run --filter t3 build:bundle: pass (apps/server/dist/bin.mjs present)
  • vp run --filter @t3tools/web build: pass (apps/web/dist present)

Not merged. Required ARC check is still pending.

@nullStack65

Copy link
Copy Markdown
Owner Author
{"reviewed_head":"752450527a2a7547ac8e691aee124fc0cbe3c0ae","reviewer":"grok-4.7-build (claudeAgent, read-only)","findings":[{"id":"remote-request-skips-served-check","severity":"nit","summary":"modelSelectionFromCommand returns undefined for delegated_task.remote.request, so the dispatch guard never checks it. Only RemoteDelegation builds that command, and only after the linked environment has accepted the model through runsModel; checking it here would compare against this machine's catalog and refuse a model only the other machine serves.","outcome":"skipped"}]}

@nullStack65
nullStack65 merged commit 0efb4d9 into release/native-0.1.10 Nov 20, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant