Repository navigation
feat(skills): feature map of every T3 surface, checked in CI - #116
Merged
Merged
Conversation
… and keybindings Agents had no shared names for T3's pages, panels and controls, so UI requests got guessed at. The test-t3-app skill now carries a user-facing feature map (after Lauren Tan's runtime verification feature map): every page, panel, control and mobile screen with its visible label and how to reach it. scripts/feature-map.test.ts fails when a web route or keybinding command is missing from the map, or the map names one that no longer exists. ARC CI runs it; AGENTS.md and both test skills point at the map. Model: claude-opus-5-5 Task: implementation Agent: Claude Code (CLO-868 feature map lane) Lane: magpie Harness: t3/claude-code Model-family: Claude Model-generation: 5.5 Skills-SHA: df60fa7be83ccc7a8e3c64e3c58ba9ed7a84cfc4 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Typecheck's nodeBuiltinImport diagnostic rejected node:fs and node:path in the check; it now uses the FileSystem and Path services like the other script tests. Model: claude-opus-5-5 Task: implementation Agent: Claude Code (CLO-868 feature map lane) Lane: magpie Harness: t3/claude-code Model-family: Claude Model-generation: 5.5 Skills-SHA: df60fa7be83ccc7a8e3c64e3c58ba9ed7a84cfc4 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…rams Review found five labels that were not the visible strings, a stale-route check that skipped every route with a $param, and route discovery that missed subfolders and wrapped calls. The labels now match source, the route pattern accepts params, discovery reads the routes folder recursively, the duplicate route index is gone, and the conventions say feature ids stay in bold. Model: claude-opus-5-5 Task: implementation Agent: Claude Code (CLO-868 feature map lane) Lane: magpie Harness: t3/claude-code Model-family: Claude Model-generation: 5.5 Skills-SHA: df60fa7be83ccc7a8e3c64e3c58ba9ed7a84cfc4 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
Author
{"reviewed_head":"e30cd85ede68604b8c9c604ea2ed87a42646ffe1","reviewer":"grok-4.7-build (claudeAgent, read-only)","findings":[]}Independent review of the feature map PR found nothing. Merged as 45452ed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Agents had no shared names for T3's pages, panels and controls, so "the thingy in the sidebar" got guessed at. This adopts the feature map from Lauren Tan's talk "All Code Is Slop (Except Mine)": a site map of every feature from the user's point of view.
.agents/skills/test-t3-app/references/feature-map.md: every page, panel, control, settings section, desktop shell feature and mobile screen, with a stable id, the visible label and how to reach it (click path and keybinding).scripts/feature-map.test.tsfails when a web route (createFileRoute) or a keybinding command (STATIC_KEYBINDING_COMMANDS) is missing from the map, or the map names one that no longer exists. A probe route/zz-probemade it fail withadd these routes to …: ['/zz-probe'].The check covers routes and keybinding commands, which can be listed from code. Mobile screens and in-page controls are on the map but not checked mechanically. The earlier verify-t3code map (#102) landed only on
main; this one is on the live release line.Deploy: none
Model: claude-opus-5-5
Task: CLO-868 feature map lane
🤖 Generated with Claude Code