Repository navigation
fix(server): a model alert is not dropped because a newer run fell back too - #104
Merged
nullStack65 merged 1 commit intoNov 19, 2026
Conversation
…ck too Delivery-time staleness treated any newer completed run as a fix. A thread that falls back on every run then lost its alert whenever a second run finished before delivery, which broke the delegated-completion model alert test on the release branch. A model alert now stays until a healthy run clears the thread's degraded mark, or the thread is settled, archived, deleted or on another provider. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This was referenced Nov 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
c77129892d(#100) failed its qualification run 44576516975:DelegatedCompletionDelivery.test.ts> "alerts the watcher and the parent once when a child ran another model" got no alert text. #100's own CI never ran on its head, and my local verification skipped this file, so it first ran after merge.Cause (confirmed on R720 by the verification child; see the thread comment below if it differs): delivery-time staleness treated any newer completed run as a fix. A thread that falls back on every run lost its alert when a second run finished before delivery. A model alert now stays until a healthy run clears the thread's degraded mark, or the thread is settled, archived, deleted or on another provider. Thread-event and usage-limit incident alerts keep the newer-run rule.
Test: a model alert survives a newer run that also fell back; a thread event does not. The failing suite is in the CI list and is re-run on R720 with the other server tests from the CI step.
Deploy: fleet
🤖 Generated with Claude Code