Add the split, takeUntilIncluding, and skipUntilIncluding functions to Seq/List/FSeq/Array

[ntwilson]

I was going for split, but the Seq implementation of split depended on takeUntilIncluding and skipUntilIncluding, which seemed useful enough to make public, so I added them to Seq (and then added them to all the other modules too)

[Copilot]

Pull request overview

This PR extends SafetyFirst’s collection helpers by adding split, takeWhileIncluding, and skipUntilIncluding across Seq, List, Array, and FSeq/FiniteSeq, along with accompanying tests and release note updates.

Changes:

• Add takeWhileIncluding and skipUntilIncluding to Seq, List, Array, and FiniteSeq/FSeq (plus NonEmpty wrappers where applicable).
• Add split implementations for Seq (lazy inner/outer) and for strict collections (List/Array/FiniteSeq).
• Add/expand specs for the new functions and update ReleaseNotes.md.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
SafetyFirst/Seq.fs	Adds skipUntilIncluding, takeWhileIncluding, split, and updates Seq.NonEmpty.split to delegate to the new Seq.split.
SafetyFirst/List.fs	Adds skipUntilIncluding, takeWhileIncluding, split, plus List.NonEmpty.takeWhileIncluding.
SafetyFirst/FiniteSeqModule.fs	Adds FiniteSeq/FSeq implementations for skipUntilIncluding, takeWhileIncluding, and split, plus NonEmpty wrappers.
SafetyFirst/Array.fs	Adds skipUntilIncluding, takeWhileIncluding, split, and updates Array.NonEmpty.split to delegate to the new Array.split.
SafetyFirst.Specs/SeqSpec.fs	Adds test coverage for Seq.takeWhileIncluding, Seq.skipUntilIncluding, and Seq.split.
SafetyFirst.Specs/ListSpec.fs	Adds tests for List.split, plus coverage for List.(NonEmpty.)takeWhileIncluding and List.skipUntilIncluding.
SafetyFirst.Specs/FSeqSpec.fs	Adds tests for FSeq.split, FSeq.takeWhileIncluding, and FSeq.skipUntilIncluding; simplifies a helper to use NonEmpty.assume.
SafetyFirst.Specs/ArraySpec.fs	Adds tests for Array.split, Array.takeWhileIncluding, and Array.skipUntilIncluding (plus NonEmpty coverage).
ReleaseNotes.md	Updates release notes to list the newly added functions.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 5 comments.

Comments suppressed due to low confidence (1)

SafetyFirst/FiniteSeqModule.fs:2439

• Doc example code is missing a space between the first argument and the list argument (FSeq.NonEmpty.create 1[ ... ]), which makes the snippet invalid F#. Update to FSeq.NonEmpty.create 1 [ ... ].

    /// split ((=) 100) (FSeq.NonEmpty.create 1[2;3;100;100;4;100;5;6])
    ///   //returns ([[1;2;3;100];[100];[4;100];[5;6]])

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.