Repository navigation
Let the Card Builder add the stars button for a package under 40 stars - #351
Merged
Merged
Conversation
nstarman
added a commit
that referenced
this pull request
Oct 6, 2026
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Contributor
|
Preview: https://44cd900e.nstarkman-space.pages.dev Built from |
nstarman
force-pushed
the
add/builder-stars-under-threshold
branch
6 times, most recently
from
October 6, 2026 21:17
d8dd9e3 to
e97f2ca
Compare
Under STARS_MIN the stars link is optional: a card's own buttons (all) leave it out, but a name that lists it shows it, and the Card Builder offers it as an unticked pill. The embed page renders every link a card could show (stars included, hidden under all), as it does for the rest, so the name chooses. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
nstarman
force-pushed
the
add/builder-stars-under-threshold
branch
from
October 6, 2026 21:24
e97f2ca to
93048e8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changing code or schema
What and why: #345 stops showing the stars button for a package with fewer than 40 stars (
STARS_MIN). That should be a default, not a wall: the Card Builder should be able to add it anyway.STARS_MINthe stars link is optional: a card's own buttons (buttons:all) leave it out, but a name that lists it shows it —buttons:code,docs,stars. Nothing new in the grammar; naming a button asks for it.all, as the other parts are — so the name chooses. The site's own cards are unchanged (they never name it).buttons:code,docs,stars; unticking goes back tobuttons:all. For a package with enough stars nothing changes.it.linksentries gain a fourth element,optional;ownKeys(it)is the keysallmeans, andcontrolOps,fitNameandlinksOfuse it where they compared with every key.Card.astrochanged); the layouts in it are identical.Checked in a browser on /tools/card/ with coordinax (38 stars): pill unticked and no star in the preview; ticked, the star appears and the name is
…buttons:code,docs,stars; unticked, back toall. unxt (70) is as before.Screenshots
coordinax has 38 stars. In the Card Builder its stars pill starts unticked, and the card has no star button:
Ticked, the card shows it and the name lists it (
buttons:code,docs,stars):npm run test:schemapasses; 691 unit tests (new: optional links andcardFace, the builder's pill, controls and round trips) and the build pass🤖 Generated with Claude Code