Repository navigation
Make fellowships positions, not grants - #350
Merged
Merged
Conversation
A fellowship that was awarded is still a position. Positions may now carry a tier, which places them under Grants & Fellowships instead of Professional Appointments; section matches gain a `not` clause to leave them out of the latter. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Contributor
|
Preview: https://af6c8915.nstarkman-space.pages.dev Built from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changing code or schema
What and why: Massey Junior Fellow, the Brinson Prize Fellowship and the Pacific Postdoc Program were `type: grant`, but a fellowship is a position that was awarded, not funding or an award.
Massey, Brinson and PPP are now `type: position`, with `institution` and `role`.
A position may carry `tier` (and `amount` / `funder`). `tier: major` places it under Grants & Fellowships rather than Professional Appointments.
A section's `match` gains `not`, used by Professional Appointments to leave tiered positions out.
`tests/presets.test.js` checks the three land in `grants-major` and the MIT postdoc stays in `positions`.
`npm run test:schema` passes
If a `link.rel` value or a `type` was added, every renderer was updated in this PR (none added)
If a constraint was added, `schema/invalid/` gained a fixture (none added; `tier` on a position is optional)
No screenshots: the CV placement is data-driven and covered by the test; the full site build did not run locally.
🤖 Generated with Claude Code