Repository navigation
Write each place's coordinates once; same-campus names are sameAs - #335
Merged
Merged
Conversation
13 names that were a second copy of another entry (SAO and the CfA, the two spellings of Chicago, Bologna, Heidelberg, Copenhagen, ...) now point at it with sameAs. A resolver, src/lib/places.js, is the one way the maps read config/places.json, and a test fails on repeated coordinates. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Contributor
|
Preview: https://ea084fa8.nstarkman-space.pages.dev Built from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changing code or schema
What and why: Follow-up to #334.
config/places.jsonrepeated coordinates for names that are the same campus, so the two could drift (and the Smithsonian Astrophysical Observatory entry was hand-copied "same place as" the CfA). Each coordinate is now written once.{ "sameAs": "<other name>" }.src/lib/places.js(locate) is the one way the collaborator and conference maps read the file.tests/places.test.jsfails on asameAsthat points nowhere or at a chain, and on two entries with the same coordinates.geocode-places.mjsand AGENTS.md describe the convention.The map should look the same; a few pins moved by under 3 km.
npm testpasseslink.relortypeadded; no schema changeScreenshots
The collaborator map on /research/.
JavaScript off
JavaScript on
🤖 Generated with Claude Code