Skip to content

Replace parallel EC GET with paired stream #3998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
cthulhu-rider wants to merge 2 commits into
base: master
Choose a base branch
from

sn/object: GET EC object payload in two streams

087994b
Select commit
Loading
Failed to load commit list.
Draft

Replace parallel EC GET with paired stream #3998

sn/object: GET EC object payload in two streams
087994b
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed May 21, 2026 in 0s

27.80% (-0.54%) compared to 84ededb

View this Pull Request on Codecov

27.80% (-0.54%) compared to 84ededb

Details

Codecov Report

❌ Patch coverage is 5.43580% with 1009 lines in your changes missing coverage. Please review.
✅ Project coverage is 27.80%. Comparing base (84ededb) to head (087994b).

Files with missing lines Patch % Lines
pkg/services/object/get.go 2.55% 720 Missing and 5 partials ⚠️
pkg/services/object/get/ec.go 2.31% 167 Missing and 2 partials ⚠️
pkg/services/object/proto.go 0.00% 46 Missing ⚠️
pkg/services/object/server.go 41.17% 19 Missing and 1 partial ⚠️
pkg/network/cache/clients.go 40.90% 13 Missing ⚠️
internal/object/wire.go 40.00% 9 Missing ⚠️
internal/protobuf/seekers.go 0.00% 8 Missing ⚠️
pkg/services/object/util.go 33.33% 5 Missing and 3 partials ⚠️
pkg/services/object/get/service.go 0.00% 5 Missing ⚠️
pkg/services/object/get/util.go 0.00% 3 Missing ⚠️
... and 2 more
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3998      +/-   ##
==========================================
- Coverage   28.33%   27.80%   -0.54%     
==========================================
  Files         681      681              
  Lines       45753    46763    +1010     
==========================================
+ Hits        12964    13002      +38     
- Misses      31556    32524     +968     
- Partials     1233     1237       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov