Experiment with Go http#3973
Draft
roman-khimov wants to merge 4 commits into
Draft
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3973 +/- ##
==========================================
- Coverage 28.34% 28.18% -0.17%
==========================================
Files 681 681
Lines 45756 46016 +260
==========================================
Hits 12969 12969
- Misses 31555 31815 +260
Partials 1232 1232 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
What we need here is to finish this prototype with an end-to-end GET data transport over HTTP, from S3 gateway (additional branch there) to SN. Many things can be improved here performance-wise, but we're interested in a quick prototype first, so many of object service internals are still left as is and just two proto-encoded byte arrays are pushed to the client (that needs to parse them). |
Let's see how it goes. Signed-off-by: Roman Khimov <roman@nspcc.ru>
Signed-off-by: Roman Khimov <roman@nspcc.ru>
Accept protobufs, reply with protobufs. TODO: * deal with TTL/new requests (create new ones signed by container node) * create new requests for EC parts * create and handle them client-side Signed-off-by: Roman Khimov <roman@nspcc.ru>
- implement copyHTTPStream. - GetHTTP: read body with io.ReadAll, emit apistatus.Status protobuf in non-200 responses, map errors to 4xx/5xx. - continueHTTP: normalize peer URI scheme, set Content-Type, surface non-200 upstream status. - network/cache: h2c http.Client for inter-SN forwarder. Signed-off-by: Andrey Butusov <andrey@nspcc.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.