Skip to content

refactor: rename Nack::Spec.no_entity_body? to no_content? #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
himura467 merged 1 commit into from
Nov 2, 2026
Merged

refactor: rename Nack::Spec.no_entity_body? to no_content? #75

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/nack/spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ def valid_content_length?(value)
value.is_a?(String) && value.ascii_only? && /\A[0-9]+\z/.match?(value)
end

def no_entity_body?(status, request)
def no_content?(status, request)
request.request_method.get_string == "HEAD" ||
((100..199).cover?(status) && status != 101) || status == 204 || status == 205 || status == 304
end
Expand Down
18 changes: 9 additions & 9 deletions test/spec_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,18 +52,18 @@
Nack::Spec.valid_content_length?(:a).must_equal false
end

it "knows which responses carry no entity body" do
it "knows which responses carry no content" do
request = Struct.new(:request_method)
get = request.new(IO::Buffer.for("GET"))
head = request.new(IO::Buffer.for("HEAD"))
Nack::Spec.no_entity_body?(100, get).must_equal true
Nack::Spec.no_entity_body?(199, get).must_equal true
Nack::Spec.no_entity_body?(204, get).must_equal true
Nack::Spec.no_entity_body?(205, get).must_equal true
Nack::Spec.no_entity_body?(304, get).must_equal true
Nack::Spec.no_entity_body?(200, head).must_equal true
Nack::Spec.no_entity_body?(101, get).must_equal false
Nack::Spec.no_entity_body?(200, get).must_equal false
Nack::Spec.no_content?(100, get).must_equal true
Nack::Spec.no_content?(199, get).must_equal true
Nack::Spec.no_content?(204, get).must_equal true
Nack::Spec.no_content?(205, get).must_equal true
Nack::Spec.no_content?(304, get).must_equal true
Nack::Spec.no_content?(200, head).must_equal true
Nack::Spec.no_content?(101, get).must_equal false
Nack::Spec.no_content?(200, get).must_equal false
end

it "accepts interim statuses" do
Expand Down
Loading