Skip to content

feat: add Nack::Headers#delete_if #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
himura467 merged 1 commit into from
Nov 1, 2026
Merged

feat: add Nack::Headers#delete_if #72

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions lib/nack/headers.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,11 @@ def delete(name)
self
end

def delete_if(&block)
@fields.reject!(&block)
self
end

def to_a
@fields.dup
end
Expand Down
6 changes: 6 additions & 0 deletions test/spec_headers.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,12 @@
headers.to_a.must_equal [["b", "2"]]
end

it "deletes the fields the block selects" do
headers = Nack::Headers.new([["a", "1"], ["b", "2"], ["a", "3"]])
headers.delete_if { |name, value| name == "a" && value == "3" }.must_be_same_as headers
headers.to_a.must_equal [["a", "1"], ["b", "2"]]
end

it "does not alias the internal storage" do
fields = [["a", "1"], ["b", "2"], ["a", "3"]]
headers = Nack::Headers.new(fields).add("c", "4")
Expand Down
Loading