Repository navigation
feat: add Nack::Request - #71
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #16
Nack::Request, which wraps any object satisfying SPEC.md section 3 and reads each field lazily, copying a buffer into a frozenStringonly on first access.request_method,script_name,path_info,query_string,headersandbodywritable. Anilpath or query reads as"", and*stays"*".GET,POSTandcookiesare cached against the exact object they were parsed from, so replacingquery_string,bodyor a header reparses them.paramsmergesGETandPOSTon each call.POSTreads only anapplication/x-www-form-urlencodedbody, chunk by chunk throughbody.read, and leaves any other body unread.cookiesreturns values as sent, without percent-decoding, keeps the first value of a repeated name (RFC 6265 §5.4), and reads a pair without=as a cookie with an empty name (RFC 6265bis).hostandportcome fromauthorityonly, withportfalling back to the default forscheme. A malformed authority or a port above 65535 yieldsnilfor both.remote_addressinstead of theipthe issue asks for: it returns the transport peer as SPEC.md defines it, including theunix:form, not a client IP behind proxies as Rack'sipdoes.connection,protocol,authority,content_length,variable,trailers,informandtunnelthrough from the bridge, and addscontext.