Lots of fixes - #69
Merged
Merged
Conversation
✅ NSchema.Postgres✅ ReleaseVersion 5.6.1 is valid (latest published: 5.6.0). Changelog entry for 5.6.1 is present. ✅ TestsAll 257 tests passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed
tinyint,nchar,nvarcharandbinaryare written assmallint,character,character varyingandbytea, but the engine's vocabulary is read from its own catalog and so never names them, leaving a plan that rendered the column correctly and then refused it as an unresolved type. They now compare equal to the type they are rendered as.varbinarylength no longer drifts.byteacarries none, so a declared one was never read back and every plan asked to change the column again.RESTARTwas appended to every identity alter. Only a start that actually moved carries aRESTARTnow, and that case is reported as a data hazard.