-
-
Notifications
You must be signed in to change notification settings - Fork 511
fix: docs tab repeats the package name twice in the header #3101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ghostdevv
merged 3 commits into
npmx-dev:main
from
WilhelmBerggren:fix/package-route-encoded-scope-docs
Jul 31, 2026
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| import { describe, expect, it } from 'vitest' | ||
| import { docsRoute } from '~/utils/router' | ||
|
|
||
| describe('docsRoute', () => { | ||
| it('emits a scoped name as two path segments (literal slash, not %2F)', () => { | ||
| // A single "@org/name" segment would be URL-encoded to "@org%2Fname"; the | ||
| // docs route must keep the scope slash literal by splitting it into two. | ||
| expect(docsRoute('@vitest/pretty-format', '4.1.10')).toEqual({ | ||
| name: 'docs', | ||
| params: { path: ['@vitest', 'pretty-format', 'v', '4.1.10'] }, | ||
| }) | ||
| }) | ||
|
|
||
| it('handles an unscoped name with a version', () => { | ||
| expect(docsRoute('nuxt', '4.2.0')).toEqual({ | ||
| name: 'docs', | ||
| params: { path: ['nuxt', 'v', '4.2.0'] }, | ||
| }) | ||
| }) | ||
|
|
||
| it('omits the version marker when no version is given', () => { | ||
| expect(docsRoute('@vitest/pretty-format')).toEqual({ | ||
| name: 'docs', | ||
| params: { path: ['@vitest', 'pretty-format'] }, | ||
| }) | ||
| }) | ||
|
|
||
| it('strips whitespace from the version', () => { | ||
| expect(docsRoute('nuxt', ' 4.2.0 ')).toEqual({ | ||
| name: 'docs', | ||
| params: { path: ['nuxt', 'v', '4.2.0'] }, | ||
| }) | ||
| }) | ||
|
|
||
| it('keeps a package literally named "v" separate from the version marker', () => { | ||
| expect(docsRoute('v', '1.0.0')).toEqual({ | ||
| name: 'docs', | ||
| params: { path: ['v', 'v', '1.0.0'] }, | ||
| }) | ||
| }) | ||
|
|
||
| it('handles a scoped package whose name is "v"', () => { | ||
| expect(docsRoute('@org/v', '1.0.0')).toEqual({ | ||
| name: 'docs', | ||
| params: { path: ['@org', 'v', 'v', '1.0.0'] }, | ||
| }) | ||
| }) | ||
| }) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.