chore: adopt typescript-native-bridge - #3088
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
📝 WalkthroughSummary by CodeRabbit
WalkthroughChangesApp-config typing
Cached fetch delegation
TypeScript workspace override
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
📊 Dependency Size ChangesWarning This PR adds 12.4 MB of new dependencies, which exceeds the threshold of 200 kB.
Total size change: 12.4 MB |
ghostdevv
left a comment
There was a problem hiding this comment.
Could you give some more context around this issue?
|
|
| event.context.cachedFetch = async (url: string, options?: any) => { | ||
| return { | ||
| data: await globalThis.$fetch(url, options), | ||
| data: await fetchWrapper(url, options), |
There was a problem hiding this comment.
this seems like it's a behavior change?
There was a problem hiding this comment.
fetchWrapper has already been assigned to globalThis.$fetch above. Using globalThis.$fetch here causes the TS2321 error: "Excessive stack depth comparing types ..."
|
|
||
| declare module '@nuxt/schema' { | ||
| interface AppConfig { | ||
| interface CustomAppConfig { |
There was a problem hiding this comment.
The AppConfig interface merges in a literal object inferred from the runtime value, where prNumber is always inferred as null. Therefore, overriding the type of buildInfo directly on AppConfig causes the TS2430 error: "Interface 'AppConfig' incorrectly extends interface 'MergedAppConfig<...>'."
Adjusts the Nuxt app config augmentation and cached fetch wrapper to avoid two tsgo diagnostic differences exposed by the migration.
This pull request was created with assistance from a code agent.