Skip to content

fix: allow empty peer dependency metadata #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pengyuayn wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: allow empty peer dependency metadata #210

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions test/package-json.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
import t from 'tap'
import type { PackageJSON } from '../types/index.d.ts'

t.test('PackageJSON peerDependenciesMeta allows an empty metadata object', (t) => {
const pkg: PackageJSON = {
name: 'peer-meta-empty',
version: '1.0.0',
peerDependencies: {
react: '^18.0.0',
},
peerDependenciesMeta: {
react: {},
},
}

t.same(pkg.peerDependenciesMeta, { react: {} })
t.end()
})
2 changes: 1 addition & 1 deletion types/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ interface Overrides {

// https://docs.npmjs.com/cli/v10/configuring-npm/package-json#peerdependenciesmeta
interface PeerDependencyMeta {
optional: boolean
optional?: boolean
}

// https://docs.npmjs.com/cli/v10/configuring-npm/package-json#license
Expand Down