Conversation
repeatable, one range each, and it replaces the sidecar for that run the same way every other flag beats the file it has an equivalent in
with no file named it fell through to the watch folder and cut the same seconds out of every queued recording, overriding each one's own sidecar, and with keep_original = false deleted the sources and sidecars it had just overridden. an empty value counted as a cut request the same way, suppressing a real sidecar while adding no range to replace it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
--cut, so cutting a stretch out of a recording no longer needs a.cutsfile next to it:The flag repeats, one range each, the same way the file takes one range per line, and it understands
0andendfor the clip edges exactly like the file does. When both are present the flag wins and the log says which sidecar it ignored. A range typed on the command line is an instruction for that one run, and quietly mixing it with the file's ranges would be the worse surprise of the two.Most of the diff is a refactor that had to come first. The per-range validation lived inside the loop that reads the sidecar, with every rejection message hardcoded to name the file, so the flag had nothing it could reuse. That moved into one function that takes the range's origin as an argument, so both paths now share the same checks and the same wording, and the file path's log lines come out unchanged.
Testing it turned up two ways to lose work, both fixed here.
--cutwith the filename forgotten fell through to watch-folder mode, where it cut the same seconds out of every recording in the queue, overrode whatever sidecar each of them carried, and withkeep_original = falsedeleted the sources and the sidecars it had just overridden.An empty value did the same thing one level up. A wrapper expanding a variable it never set still counted as a cut being requested, so it suppressed the recording's real sidecar and then had no range to replace it with. Both now stop with a usage error before anything is encoded.