Skip to content

Fix highlight clicks that never scrolled the matching comment card - #11

Closed
qqlabs wants to merge 1 commit into
notsuhas:mainfrom
qqlabs:qhsu/fix-highlight-click-rail-reveal
Closed

qqlabs wants to merge 1 commit into
notsuhas:mainfrom
qqlabs:qhsu/fix-highlight-click-rail-reveal

Conversation

@qqlabs

@qqlabs qqlabs commented Sep 30, 2026

Copy link
Copy Markdown

Summary

  • Clicking a painted quote now keeps working after in-iframe navigation (the annotate client would stay in experience mode and swallow the click).
  • Revealing the matching rail card waits until it is laid out, then jumps the comments scroller to the top of the panel instead of a slow centered smooth-scroll.
  • The revealed card gets a short amber ring so it is obvious in a long resolved list.

notsuhas/postplan has issues disabled, so there is no issue to link. This is the same viewer/rail fix that landed on the qqlabs instance as #6 / #10 / #11 / plivo-labs#12 / plivo-labs#13, squashed onto current upstream/main.

Test plan

  • Open a page with many resolved comments, Comments rail open, click a highlighted quote that is not at the top of the rail.
  • Confirm the matching card jumps to the top of the side panel with a ring (not a long smooth scroll, not a different nearby card).
  • Navigate inside the iframe to another page on the same site, then click a highlight: the rail should still reveal that thread.
  • Click the same highlight twice: it should still scroll/emphasize on the second click.

Made with Cursor

A click on a painted quote could miss the rail after in-iframe navigation, after a resolved-tab remount, or if the card was not laid out yet. Jump the rail scroller to that card at the top and ring it so a long list is still obvious.
@qqlabs qqlabs closed this Sep 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant