Write the report front end in TypeScript - #64
Merged
Merged
Conversation
Port the report enhancement script to strict TypeScript in frontend/, compiled to the packaged report_enhance.js. The compiled file stays committed so pip install needs no Node; check:frontend fails CI when it is stale. The Python core is unchanged.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Python core, TypeScript front end (the Inspect AI split).
frontend/report_enhance.ts: the sortable-table and filter enhancement, strict mode (strict,exactOptionalPropertyTypes, no unused locals/params), wrapped in an IIFE so no globals leak.src/evalarc/assets/report_enhance.jsand committed:pip install evalarcstill needs no Node, and the CSP hash covers the compiled bytes.npm run check:frontendrecompiles into a temp folder and fails if the committed JS differs or contains import/export; added to thesiteCI job. Verified it fails on a hand-edited asset.build:frontend,check:frontend,test:reports; TypeScript 7.0.2 pinned. sdist includesfrontend/.Testing
pytest: 677 passed; ruff clean.npm run test:reports(axe-core WCAG 2.2 AA, sort/filter/no-JS/print/viewer scenarios) passes against the compiled output.