Conversation
Owner
Author
|
Closed because this draft was created in the fork by mistake. Recreated against tracefinity/tracefinity as tracefinity#137. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This adds the full reusable photo-station workflow to tracing. Users can capture from a camera, crop the capture area, reuse a saved station's corners when the setup matches, save the current setup as a new station, and continue into a save-and-new loop for repeated captures.
The PR includes:
/tracecamera capture pageImplementation Notes
This PR depends on the backend APIs and management UI from the previous two PRs.
The capture page can receive a selected station and pass that station id through upload. When the backend can apply the saved station during upload, the trace editor reflects that reused station state. If the station does not match the current image, the UI disables non-matching station options and reports a warning rather than silently applying bad corners.
The trace editor station logic was extracted into a dedicated
usePhotoStationshook. That keeps station suggestions, reuse, redetect, active station state, save-as-station state, and station notices out of the already-large trace page component.This also addresses review feedback from the original larger PR:
startCamerainuseCallback.Tests
corepack pnpm@10.29.2 --dir frontend exec vitest runcorepack pnpm@10.29.2 --dir frontend lintcorepack pnpm@10.29.2 --dir frontend exec tsc --noEmitpython -m pytest backend/tests/test_photo_stations.pyCode and PR drafted with Codex