Skip to content

feat(banner): add RenderATL#8972

Merged
avivkeller merged 2 commits into
mainfrom
fast-track-banner
Jun 24, 2026
Merged

feat(banner): add RenderATL#8972
avivkeller merged 2 commits into
mainfrom
fast-track-banner

Conversation

@avivkeller

Copy link
Copy Markdown
Member

Resolves #8957 (comment) (Closes #8957)

Supersedes #8958

Fast-tracking as a foundation request, I'll land once @kyliewd approves

Signed-off-by: Aviv Keller <me@aviv.sh>
@avivkeller avivkeller requested a review from a team as a code owner June 24, 2026 20:15
@vercel

vercel Bot commented Jun 24, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
nodejs-org Ready Ready Preview Jun 24, 2026 8:18pm

Request Review

@cursor

cursor Bot commented Jun 24, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Config-only homepage banner text, dates, link, and styling type; no application logic or security-sensitive code changes.

Overview
Updates the homepage index banner in site.json to promote Node.js Interactive at RenderATL (August 12–13) instead of the previous June Security Release message.

The banner window is set to 2026-06-24 through 2026-08-14, copy and link now point to renderatl.com/tickets, and the banner type changes from warning to default.

Reviewed by Cursor Bugbot for commit ec2d7bc. Bugbot is set up for automated code reviews on this repo. Configure here.

@avivkeller avivkeller enabled auto-merge June 24, 2026 20:16
Signed-off-by: Aviv Keller <me@aviv.sh>
@kyliewd

kyliewd commented Jun 24, 2026

Copy link
Copy Markdown

lgtm

@codecov

codecov Bot commented Jun 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.41%. Comparing base (c8a83d6) to head (ec2d7bc).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8972      +/-   ##
==========================================
+ Coverage   75.34%   75.41%   +0.06%     
==========================================
  Files          98       98              
  Lines        8630     8630              
  Branches      319      318       -1     
==========================================
+ Hits         6502     6508       +6     
+ Misses       2124     2118       -6     
  Partials        4        4              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@MattIPv4 MattIPv4 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Been a just under a week since the security releases, so I guess this is okay to switch. Though I do think security releases are perhaps still more important to our users globally than a conference that is two months away.

@avivkeller

Copy link
Copy Markdown
Member Author

@MattIPv4 we aren't "switching" the banner, the security banner expired 2026-06-23T22:00:00.000Z.

Comment thread apps/site/site.json
@MattIPv4

Copy link
Copy Markdown
Member

Ah yes, perfect, I can't read dates 🤦

@avivkeller avivkeller enabled auto-merge June 24, 2026 20:23
@avivkeller avivkeller added this pull request to the merge queue Jun 24, 2026
@avivkeller avivkeller removed this pull request from the merge queue due to a manual request Jun 24, 2026
@avivkeller avivkeller merged commit 71312e2 into main Jun 24, 2026
15 checks passed
@avivkeller avivkeller deleted the fast-track-banner branch June 24, 2026 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Node.js Interactive Event Banner

4 participants