Skip to content

chore(open-next): avoid the use of DurableObjects by using queueCache with memoryQueue instead#8878

Open
dario-piotrowicz wants to merge 1 commit intonodejs:mainfrom
dario-piotrowicz:dario/queueCache_plus_memoryQueue
Open

chore(open-next): avoid the use of DurableObjects by using queueCache with memoryQueue instead#8878
dario-piotrowicz wants to merge 1 commit intonodejs:mainfrom
dario-piotrowicz:dario/queueCache_plus_memoryQueue

Conversation

@dario-piotrowicz
Copy link
Copy Markdown
Member

@dario-piotrowicz dario-piotrowicz commented May 5, 2026

Description

The use of DurableObjects breaks the open-next skew protection, so in order to make sure skew protection works this PR updates the queue to use queueCache with memoryQueue instead of durable objects

Validation

Site built and deployed to my personal account: https://8bf0874a-nodejs-website-1.dario-test.workers.dev

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run pnpm format to ensure the code follows the style guide.
  • I have run pnpm test to check if all tests are passing.
  • I have run pnpm build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 5, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
nodejs-org Ready Ready Preview May 5, 2026 11:41pm

Request Review

@codecov
Copy link
Copy Markdown

codecov Bot commented May 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.23%. Comparing base (ae82cde) to head (75115e7).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8878      +/-   ##
==========================================
+ Coverage   73.18%   73.23%   +0.04%     
==========================================
  Files         102      102              
  Lines        8623     8623              
  Branches      314      313       -1     
==========================================
+ Hits         6311     6315       +4     
+ Misses       2311     2307       -4     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dario-piotrowicz dario-piotrowicz marked this pull request as ready for review May 6, 2026 15:54
Copy link
Copy Markdown
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (I can not approve here it seems).

Do we need to add a delete migration for former DOs?

@dario-piotrowicz
Copy link
Copy Markdown
Member Author

LGTM (I can not approve here it seems).

Thanks 🙂

Do we need to add a delete migration for former DOs?

I think a delete migration is used when a class is deleted but the durable object binding is still used.
Since here we are instead completely removing the durable object I think that the simplest / most appropriate way to delete it is doing so though the dashboard. Don't you think?

@vicb
Copy link
Copy Markdown
Contributor

vicb commented May 7, 2026

the simplest / most appropriate way to delete it is doing so though the dashboard

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants