Skip to content

ci: codify Vercel install + ignore commands#8755

Merged
MattIPv4 merged 1 commit into
mainfrom
MattIPv4/codify-vercel-commands
Mar 24, 2026
Merged

ci: codify Vercel install + ignore commands#8755
MattIPv4 merged 1 commit into
mainfrom
MattIPv4/codify-vercel-commands

Conversation

@MattIPv4

@MattIPv4 MattIPv4 commented Mar 22, 2026

Copy link
Copy Markdown
Member

Description

Instead of managing these in Vercel's UI only, where we recently ran into an issue of these settings being wiped/not defined as we had expected them to be, this codifies them in our repository, ensuring they're always set and any changes are properly versioned.

Validation

Schema valid.

https://vercel.com/docs/project-configuration/vercel-json

https://vercel.com/openjs/nodejs-org/settings/build-and-deployment

Related Issues

N/A

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run pnpm format to ensure the code follows the style guide.
  • I have run pnpm test to check if all tests are passing.
  • I have run pnpm build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@vercel

vercel Bot commented Mar 22, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
nodejs-org Ready Ready Preview Mar 22, 2026 2:21pm

Request Review

@github-actions

Copy link
Copy Markdown
Contributor

👋 Codeowner Review Request

The following codeowners have been identified for the changed files:

Team reviewers: @nodejs/nodejs-website @nodejs/web-infra

Please review the changes when you have a chance. Thank you! 🙏

@MattIPv4 MattIPv4 marked this pull request as ready for review March 22, 2026 14:15
@MattIPv4 MattIPv4 requested review from a team as code owners March 22, 2026 14:15
Copilot AI review requested due to automatic review settings March 22, 2026 14:15
@github-actions

github-actions Bot commented Mar 22, 2026

Copy link
Copy Markdown
Contributor

📦 Build Size Comparison

Summary

Metric Value
Old Total Size 3.52 MB
New Total Size 3.52 MB
Delta 0 B (0.00%)

Changes

➕ Added Assets (1)
Name Size
.next/static/chunks/7cbce72c3d0d7804.js 208.90 KB
➖ Removed Assets (1)
Name Size
.next/static/chunks/5c823bce7dcba1f2.js 208.90 KB

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Codifies Vercel “install” and “ignore” behavior in-repo to avoid relying on Vercel UI settings that can be lost/reset.

Changes:

  • Updates Vercel integration documentation to reference the repo-configured settings.
  • Adds apps/site/vercel.json defining installCommand and ignoreCommand.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
docs/technologies.md Updates documentation to reference Vercel config in vercel.json
apps/site/vercel.json Adds Vercel project configuration for install and ignored deployments

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread docs/technologies.md Outdated
Comment thread docs/technologies.md Outdated
Comment thread apps/site/vercel.json Outdated
Comment thread apps/site/vercel.json
@MattIPv4 MattIPv4 force-pushed the MattIPv4/codify-vercel-commands branch from da829ee to 01c4d4e Compare March 22, 2026 14:20
@codecov

codecov Bot commented Mar 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.27%. Comparing base (7ec1349) to head (b46dad1).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8755   +/-   ##
=======================================
  Coverage   75.27%   75.27%           
=======================================
  Files         105      105           
  Lines        9242     9242           
  Branches      326      326           
=======================================
  Hits         6957     6957           
  Misses       2283     2283           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MattIPv4 MattIPv4 added auto-merge Ready to automatically merge after being open for 48 hours and removed auto-merge Ready to automatically merge after being open for 48 hours labels Mar 22, 2026
@avivkeller avivkeller added the auto-merge Ready to automatically merge after being open for 48 hours label Mar 23, 2026
@MattIPv4 MattIPv4 added this pull request to the merge queue Mar 24, 2026
Merged via the queue into main with commit b5c8425 Mar 24, 2026
19 checks passed
@MattIPv4 MattIPv4 deleted the MattIPv4/codify-vercel-commands branch March 24, 2026 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-merge Ready to automatically merge after being open for 48 hours

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants