Skip to content

fix: Remove unnecessary margin from sidebar item#8084

Merged
ovflowd merged 2 commits into
nodejs:mainfrom
adi-ray:main
Aug 24, 2025
Merged

fix: Remove unnecessary margin from sidebar item#8084
ovflowd merged 2 commits into
nodejs:mainfrom
adi-ray:main

Conversation

@adi-ray

@adi-ray adi-ray commented Aug 17, 2025

Copy link
Copy Markdown
Contributor

Description

Eliminated the "loose pixel" which was being shown between sidebar items.

Validation

Before:
image
After:
image

Related Issues

Fixes #8082

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run pnpm format to ensure the code follows the style guide.
  • I have run pnpm test to check if all tests are passing.
  • I have run pnpm build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

Copilot AI review requested due to automatic review settings August 17, 2025 08:47
@adi-ray adi-ray requested a review from a team as a code owner August 17, 2025 08:47

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a visual issue by removing unnecessary margin from sidebar items that was causing "loose pixels" to appear between sidebar items.

  • Removes the mb-px Tailwind CSS class from sidebar items to eliminate spacing gaps
  • Addresses a UI consistency issue where unwanted pixel spacing was visible between navigation items

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@vercel

vercel Bot commented Aug 17, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
nodejs-org Ready Ready Preview Aug 17, 2025 10:03am

@AugustinMauroy AugustinMauroy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikeesto mikeesto left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a suggestion... if we add a gap of 1px to:

then the spacing will remain as it currently is

@ovflowd

ovflowd commented Aug 17, 2025

Copy link
Copy Markdown
Member

Am I the only one that feels they're too close together now?

@github-actions

github-actions Bot commented Aug 17, 2025

Copy link
Copy Markdown
Contributor

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 93 🟢 100 🟢 100 🟢 100 🔗
/en/about 🟢 97 🟢 97 🟢 100 🟠 88 🔗
/en/about/previous-releases 🟢 99 🟢 93 🟢 100 🟠 89 🔗
/en/download 🟢 93 🟢 100 🟢 100 🟢 100 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 100 🔗

@avivkeller

Copy link
Copy Markdown
Member

Am I the only one that feels they're too close together now?

bump @adi-ray

@adi-ray

adi-ray commented Aug 24, 2025

Copy link
Copy Markdown
Contributor Author

Am I the only one that feels they're too close together now?

@ovflowd thanks for the note! Were you referring to the normal or the progression sidebars?

@ovflowd

ovflowd commented Aug 24, 2025

Copy link
Copy Markdown
Member

Am I the only one that feels they're too close together now?

@ovflowd thanks for the note! Were you referring to the normal or the progression sidebars?

All good! We can merge as is :)

@ovflowd ovflowd added this pull request to the merge queue Aug 24, 2025
Merged via the queue into nodejs:main with commit 5a401ab Aug 24, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extra pixel shown in Sidebar

7 participants