Skip to content

chore(🏳️‍🌈): update logo design#7866

Merged
avivkeller merged 2 commits into
mainfrom
MattIPv4/update-pride-logo
Jun 18, 2025
Merged

chore(🏳️‍🌈): update logo design#7866
avivkeller merged 2 commits into
mainfrom
MattIPv4/update-pride-logo

Conversation

@MattIPv4

@MattIPv4 MattIPv4 commented Jun 14, 2025

Copy link
Copy Markdown
Member

Description

Updates the pride variation of the Node.js logo based on discussions in the Node.js Discord.

(https://discord.com/channels/425824580918181889/1354159950787772426/1383499959168663693)

Validation

Pride variation of the logo renders nicely on the site.

Related Issues

Follow-up to #7861.

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run pnpm format to ensure the code follows the style guide.
  • I have run pnpm test to check if all tests are passing.
  • I have run pnpm build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

Copilot AI review requested due to automatic review settings June 14, 2025 20:17
@MattIPv4 MattIPv4 requested a review from a team as a code owner June 14, 2025 20:17

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

@vercel

vercel Bot commented Jun 14, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Jun 14, 2025 8:20pm

@codecov

codecov Bot commented Jun 14, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.45%. Comparing base (1ccf19c) to head (6b81db3).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7866      +/-   ##
==========================================
- Coverage   75.46%   75.45%   -0.02%     
==========================================
  Files         101      101              
  Lines        8306     8306              
  Branches      218      218              
==========================================
- Hits         6268     6267       -1     
- Misses       2036     2037       +1     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MattIPv4 MattIPv4 force-pushed the MattIPv4/update-pride-logo branch from 4b023fc to 6b81db3 Compare June 14, 2025 20:19
@nodejs nodejs locked and limited conversation to collaborators Jun 14, 2025
@MattIPv4

Copy link
Copy Markdown
Member Author

Ah, I totally missed that there's a JSX component for the logo as well. Please hold.

@AugustinMauroy

Copy link
Copy Markdown
Member

@nodejs/tsc so that you are aware

@ovflowd

ovflowd commented Jun 14, 2025

Copy link
Copy Markdown
Member

@nodejs/tsc so that you are aware

Actually logo changes need to be approved by the Foundation.

@avivkeller

avivkeller commented Jun 14, 2025

Copy link
Copy Markdown
Member

@nodejs/social (maybe they can Code own these files?)

@ovflowd ovflowd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ronag
ronag previously requested changes Jun 16, 2025

@ronag ronag left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs further approval from the foundation or TSC. Blocking until there is clarity.

@aduh95

aduh95 commented Jun 16, 2025

Copy link
Copy Markdown
Contributor

Updates the pride variation of the Node.js logo based on discussions in the Node.js Discord.

(https://discord.com/channels/425824580918181889/1354159950787772426/1383499959168663693)

I don't seem to have access to those, could we get screenshots and/or a TLDR to understand the motivations?

@ovflowd

ovflowd commented Jun 16, 2025

Copy link
Copy Markdown
Member

I think this needs further approval from the foundation or TSC. Blocking until there is clarity.

Yes, of course it needs. I've even mentioned that above :)

@avivkeller

Copy link
Copy Markdown
Member

@aduh95 TL:DR from the discussions is that the current pride logo doesn’t apply the same shading as the original logo, which has been rectified in this PR.

@kyliewd

kyliewd commented Jun 18, 2025

Copy link
Copy Markdown

i think the logo looks good. if we want to have it on our social channels though, we will need a version with only the hexagon since the full node.js mark doesnt fit in the profile photo.

@avivkeller avivkeller dismissed ronag’s stale review June 18, 2025 15:31

Dismissing, as foundation has approved

@avivkeller avivkeller added this pull request to the merge queue Jun 18, 2025
@avivkeller

Copy link
Copy Markdown
Member

@kyliewd
nodejs-icon-pride

Merged via the queue into main with commit 6272aab Jun 18, 2025
17 of 19 checks passed
@avivkeller avivkeller deleted the MattIPv4/update-pride-logo branch June 18, 2025 15:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants