Skip to content

Revert "stream: propagate destruction in duplexPair"#63830

Closed
sxa wants to merge 1 commit into
nodejs:v24.x-stagingfrom
sxa:revert_for_63487
Closed

Revert "stream: propagate destruction in duplexPair"#63830
sxa wants to merge 1 commit into
nodejs:v24.x-stagingfrom
sxa:revert_for_63487

Conversation

@sxa

@sxa sxa commented Jun 10, 2026 •
edited by MattiasBuelens
Loading

Copy link
Copy Markdown
Member

Potentially fixes issue #63487

@nodejs-github-bot

nodejs-github-bot commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/streams

@sxa sxa added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 10, 2026
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. stream Issues and PRs related to the stream subsystem. v24.x Issues that can be reproduced on v24.x or PRs targeting the v24.x-staging branch. labels Jun 10, 2026
@nodejs-github-bot

nodejs-github-bot commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/74019/

@sxa

sxa commented Jun 10, 2026

Copy link
Copy Markdown
Member Author

From an initial test build I don't think this resolves the problem (part of why I didn't tag the original issue properly at first was because I wanted to check it before publicising there)

mcollina
mcollina approved these changes Jun 10, 2026
View reviewed changes

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina

mcollina commented Jun 10, 2026

Copy link
Copy Markdown
Member

Ah just read - so it doesn't fix it?

@MattiasBuelens

MattiasBuelens commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

(part of why I didn't tag the original issue properly at first was because I wanted to check it before publicising there)

Oops, sorry about that. I thought I was being helpful by editing your description. 😅

Okay, then we have to keep digging...

@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 10, 2026
@nodejs-github-bot

nodejs-github-bot commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/74034/

@sxa

sxa commented Jun 10, 2026

Copy link
Copy Markdown
Member Author

Oops, sorry about that. I thought I was being helpful by editing your description. 😅

No worries - my attempt to keep it low profile failed ... As did the revert :-)

Okay, then we have to keep digging...

I'm going to close this now and open another one with the correct revert now that I've bisected to identify it.

@sxa sxa closed this Jun 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes

Assignees

No one assigned

Labels

needs-ci PRs that need a full CI run. stream Issues and PRs related to the stream subsystem. v24.x Issues that can be reproduced on v24.x or PRs targeting the v24.x-staging branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sxa @nodejs-github-bot @mcollina @MattiasBuelens