src: officially deprecate node::ObjectWrap#63756
Closed
addaleax wants to merge 3 commits into
Closed
Conversation
addaleax
added
semver-major
nodejs-github-bot
added
c++
addaleax
added
the
commit-queue-rebase
legendecas
approved these changes
Jun 5, 2026
Member
|
Note that this class is mentioned extensively in |
mertcanaltin
approved these changes
Jun 7, 2026
ronag
approved these changes
Jun 8, 2026
This interface has long been unmaintained and doesn't match current best practices for C++ object management. It's also simply not a good idea to have this header be part of Node.js core; since it is an inline header, user code will depend on the Node.js version it was compiled with, and there is no way to adopt changes to this header independently of changing the target Node.js version. Better userland alternatives exist and have long been more popular, notably, `node-addon-api` and, for use cases where direct V8 API access is required, `nan`. Signed-off-by: Anna Henningsen <anna@addaleax.net>
addaleax
force-pushed
the
deprecate-object-wrap
branch
from
f19268a to
450d97a
Compare
Member
Author
|
@Renegade334 Thanks for pointing this out! Can't really believe we seriously recommended this 🙃 I've added changes to account for this in 450d97a – went back and forth on the approach a bit, but ultimately decided that it would be most helpful to just include a trimmed-down copy of the class in our docs. @ronag @legendecas You may want to re-review this since there's a fairly large addition now compared to the original change |
anonrig
approved these changes
Jun 12, 2026
mertcanaltin
approved these changes
Jun 12, 2026
legendecas
approved these changes
Jun 12, 2026
github-actions
Bot
removed
the
request-ci
Collaborator
addaleax
added
the
author ready
Collaborator
Collaborator
addaleax
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in d097de8...fc28d94 |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Jun 13, 2026
This interface has long been unmaintained and doesn't match current best practices for C++ object management. It's also simply not a good idea to have this header be part of Node.js core; since it is an inline header, user code will depend on the Node.js version it was compiled with, and there is no way to adopt changes to this header independently of changing the target Node.js version. Better userland alternatives exist and have long been more popular, notably, `node-addon-api` and, for use cases where direct V8 API access is required, `nan`. Signed-off-by: Anna Henningsen <anna@addaleax.net> PR-URL: #63756 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This interface has long been unmaintained and doesn't match current best practices for C++ object management.
It's also simply not a good idea to have this header be part of Node.js core; since it is an inline header, user code will depend on the Node.js version it was compiled with, and there is no way to adopt changes to this header independently of changing the target Node.js version.
Better userland alternatives exist and have long been more popular, notably,
node-addon-apiand, for use cases where direct V8 API access is required,nan.