deps: backport V8 upstream fix for loong64 opcode 209#63731
Conversation
|
Review requested:
|
3db807e to
d51bfac
Compare
|
V8 backports should follow the process detailed at https://github.com/nodejs/node/blob/main/doc/contributing/maintaining/maintaining-V8.md#backporting-with-git-node-recommended. |
d51bfac to
dcf6977
Compare
Original commit message:
[loong64][compiler] Extend Word64Select instruction functionality
Change-Id: Iba762777642d2d2d3aa904f9afc1e9005139992e
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7801520
Reviewed-by: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn>
Commit-Queue: Liu Yu <liuyu@loongson.cn>
Reviewed-by: Darius Mercadier <dmercadier@chromium.org>
Auto-Submit: Liu Yu <liuyu@loongson.cn>
Cr-Commit-Position: refs/heads/main@{#107619}
Refs: v8/v8@c4d06ba
Co-authored-by: liujiahui <liujiahui@loongson.cn>
dcf6977 to
136cba3
Compare
|
We don't run V8 CI on loong64, but presumably |
Thank you so much for the guidance and for reviewing this!@Renegade334 Really appreciate your patience and help! |
Fixes: #63721
LoongArch64 CI is in a failed state (https://ci.nodejs.org/job/node-test-commit-loongarch64/nodes=clfs23-64/1031/)
Always reproduces on LoongArch64 when executing the make out/doc/api/addons.html command.
Error Log:
This has been fixed in the latest commit for the v8 loong64 architecture.
(Ref: https://chromium-review.googlesource.com/c/v8/v8/+/7801520).
review.googlesource.com/c/v8/v8/+/7801520)。
I verified this locally by patching deps/v8. With the patch applied, make out/doc/api/addons.html runs successfully and the crash is completely resolved.
Origin commit message:
Refs: v8/v8@c4d06ba