lib: apply minor dtls cleanups#63539
Closed
jasnell wants to merge 1 commit into
Closed
Conversation
Signed-off-by: James M Snell <jasnell@gmail.com>
Collaborator
jasnell
added
the
author ready
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #63539 +/- ##
==========================================
+ Coverage 90.30% 90.32% +0.02%
==========================================
Files 730 730
Lines 234188 234152 -36
Branches 43919 43909 -10
==========================================
+ Hits 211478 211500 +22
+ Misses 14443 14372 -71
- Partials 8267 8280 +13 🚀 New features to boost your workflow:
|
Collaborator
mcollina
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/63539 ✔ Done loading data for nodejs/node/pull/63539 ----------------------------------- PR info ------------------------------------ Title lib: apply minor dtls cleanups (#63539) Author James M Snell <jasnell@gmail.com> (@jasnell) Branch jasnell:jasnell/dtls-cleanup -> nodejs:main Labels author ready, needs-ci, dtls Commits 1 - lib: apply minor dtls cleanups Committers 1 - James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/63539 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/63539 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 24 May 2026 14:42:31 GMT ✔ Approvals: 1 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/63539#pullrequestreview-4353037573 ✘ This PR needs to wait 6 more hours to land (or 0 minutes if there is one more approval) ✔ Last GitHub CI successful ℹ Last Full PR CI on 2026-05-25T02:08:33Z: https://ci.nodejs.org/job/node-test-pull-request/73686/ - Querying data for job/node-test-pull-request/73686/ ✔ Build data downloaded ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/26708502888 |
jasnell
added a commit
that referenced
this pull request
May 31, 2026
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #63539 Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Member
Author
|
Landed in aa444b2 |
aduh95
added
dont-land-on-v22.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the object seal on the exports.