Skip to content

deps: fix V8 build failures by adding climits include#63287

Open
tjuhaszrh wants to merge 1 commit into
nodejs:mainfrom
tjuhaszrh:add-climit.h
Open

deps: fix V8 build failures by adding climits include#63287
tjuhaszrh wants to merge 1 commit into
nodejs:mainfrom
tjuhaszrh:add-climit.h

Conversation

@tjuhaszrh
Copy link
Copy Markdown
Contributor

Add explicit #include to memcopy.h to fix build failures caused by recent GCC/Clang versions removing transient inclusions of the climits header.

Fixes compilation errors when using newer toolchain versions.
Without this change the build fails with following error on aarch64:

../deps/v8/src/base/memcopy.h:57:23: error: 'CHAR_BIT' was not declared in this scope
   57 |       sizeof(count) * CHAR_BIT - bits::CountLeadingZeros(count - 1);

Refs: #63146

Add explicit #include <climits> to memcopy.h to fix build failures
caused by recent GCC/Clang versions removing transient inclusions
of the climits header.

Fixes compilation errors when using newer toolchain versions.
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/security-wg
  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels May 13, 2026
Copy link
Copy Markdown
Member

@Renegade334 Renegade334 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants