Skip to content

test: remove usage of inherits #63178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AugustinMauroy wants to merge 3 commits into
base: main
Choose a base branch
from
Open

test: remove usage of inherits #63178

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4bdfade
test: remove usage of inherits
AugustinMauroy May 7, 2026
21c7fb4
test: remove usage of inherits
AugustinMauroy May 7, 2026
dd7f554
Merge branch 'update-test' of https://github.com/AugustinMauroy/node …
AugustinMauroy May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions test/parallel/test-event-capture-rejections.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,7 @@
'use strict';
const common = require('../common');
const assert = require('assert');
const { EventEmitter, captureRejectionSymbol } = require('events');
const { inherits } = require('util');

// Inherits from EE without a call to the
// parent constructor.
Comment on lines -7 to -8

@aduh95 aduh95 May 8, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like that PR removes this check, seems important

@AugustinMauroy AugustinMauroy May 8, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wich check are you talking about ?

@aduh95 aduh95 May 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the comment I've highlighted: having an object that inherits from EE without a call to the EE constructor (relevant section of the spec is https://tc39.es/ecma262/#sec-runtime-semantics-classdefinitionevaluation)

@AugustinMauroy AugustinMauroy May 11, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about :

function NoConstructor() {}
Object.setPrototypeOf(NoConstructor.prototype, EventEmitter.prototype);
Object.setPrototypeOf(NoConstructor, EventEmitter);

we keep same behavior without using "legacy" node api

@aduh95 aduh95 Jun 20, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's what I meant in #63178 (review)

function NoConstructor() {
}
const assert = require('node:assert');
const { EventEmitter, captureRejectionSymbol } = require('node:events');

// captureRejections param validation
{
Expand All @@ -24,7 +18,7 @@ function NoConstructor() {
});
}

inherits(NoConstructor, EventEmitter);
class NoConstructor extends EventEmitter {};

function captureRejections() {
const ee = new EventEmitter({ captureRejections: true });
Expand Down
Loading