-
-
Notifications
You must be signed in to change notification settings - Fork 35.8k
inspector,http: support builtin http request bodies #62915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
GrinZero
wants to merge
22
commits into
nodejs:main
Choose a base branch
from
GrinZero:fix-http-inspector-request-body
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
7ae8df3
inspector,http: support builtin http request bodies
GrinZero 7cd0fdd
test: wrap inspector HTTP handler in mustCall
GrinZero dca5a6e
docs: add docs for dc http client
GrinZero 51cef4d
test: fix inspector HTTP handler call counts
GrinZero 91bf4e3
test: inspector-network test hasPostData
GrinZero 9e9b831
test: cover untracked inspector HTTP body events
GrinZero 4f0c790
inspector: fix requestWillBeSent body state
GrinZero d626076
inspector: format network_agent.cc
GrinZero f6f3b3f
test: cover network inspector initiator parsing
GrinZero 8bea2f3
inspector,test: reject malformed initiator stack traces
GrinZero 762b342
test: fix inspector protocol cctest formatting
GrinZero f5da783
test: cover invalid inspector network initiator stack
GrinZero 6e82187
inspector: document network initiator validation
GrinZero 4c0b7a5
inspector: drop unreachable initiator.stack schema
GrinZero 81bafbc
test: add more case
GrinZero 149c8e1
style: add comment for createInitiator
GrinZero fa8e5d0
inspector: tighten createInitiator coverage
GrinZero 3d35b9c
style: merge split variable declaration onto one line
GrinZero 821f617
docs: dc.md style change
GrinZero 7b73951
Merge branch 'nodejs:main' into fix-http-inspector-request-body
GrinZero c758658
Merge branch 'nodejs:main' into fix-http-inspector-request-body
GrinZero cd9a52e
Merge branch 'nodejs:main' into fix-http-inspector-request-body
GrinZero File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this needed vs using instanceof or some polymorphism?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I chose this method because it makes fewer changes, but changing it to instance of is not costly
Which one do you think is more suitable? I can adjust it in the right direction