test: avoid initial-break wait in restart-message#62060
Open
inoway46 wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #62060 +/- ##
==========================================
- Coverage 90.05% 90.04% -0.02%
==========================================
Files 714 714
Lines 225242 225242
Branches 42579 42570 -9
==========================================
- Hits 202843 202809 -34
- Misses 14187 14203 +16
- Partials 8212 8230 +18 🚀 New features to boost your workflow:
|
lpinca
approved these changes
Mar 3, 2026
3 tasks
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/62060 ✔ Done loading data for nodejs/node/pull/62060 ----------------------------------- PR info ------------------------------------ Title test: avoid initial-break wait in restart-message (#62060) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch inoway46:fix-flaky-debugger-restart -> nodejs:main Labels test, needs-ci Commits 1 - test: avoid initial-break wait in restart-message Committers 1 - inoway46 <inoueyuya416@gmail.com> PR-URL: https://github.com/nodejs/node/pull/62060 Refs: https://github.com/nodejs/node/issues/61762 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/62060 Refs: https://github.com/nodejs/node/issues/61762 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 01 Mar 2026 15:42:47 GMT ✔ Approvals: 1 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/62060#pullrequestreview-3884836184 ✔ Last GitHub CI successful ✘ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/23564673240 |
Collaborator
cola119
approved these changes
Apr 1, 2026
Collaborator
Collaborator
Contributor
Author
|
Since the Windows flakiness seems better now, could you please rerun CI for this PR? |
Collaborator
3aa0054 to
6611c3b
Compare
inoway46
commented
Apr 26, 2026
| // For `restart`, sync on attach/prompt instead of BREAK_MESSAGE to avoid flaky races. | ||
| // https://github.com/nodejs/node/issues/61762 | ||
| await cli.command('restart'); | ||
| await cli.waitFor(/Debugger attached\./); |
Contributor
Author
There was a problem hiding this comment.
Leaving this unchanged because this path has not shown the flake again since the fix two months ago.
ok may be the stronger sync point here too, but I’ll handle that in a separate PR after further investigation.
Contributor
Author
lpinca
approved these changes
May 5, 2026
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
cola119
approved these changes
May 10, 2026
Collaborator
Collaborator
Contributor
Author
|
I just noticed that the commit is missing the DCO sign-off, so I’ll need to amend it and force-push. Unfortunately, this will invalidate the current CI run. Sorry for the churn, and thank you for starting the CI. cc @cola119 |
Signed-off-by: inoway46 <inoueyuya416@gmail.com>
0fa8b47 to
eb34825
Compare
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #61773
test/parallel/test-debugger-restart-message.jscan still flake on macOS unusual-path runs at the initialwaitForInitialBreak(). This change syncs startup on the debugger CLI'sokconnection-completion output plus the prompt.failed CI log (main branch): https://github.com/nodejs/node/actions/runs/22545396955
Testing
./tools/test.py -p actions parallel/test-debugger-restart-message./tools/test.py -p actions -j1 --repeat 40 parallel/test-debugger-restart-messageRefs: #61762